fix anyscale template utm tracking #50236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-ray-zhang
requested review from
edoakes,
zcin,
GeneDer,
akshay-anyscale and
a team
as code owners
chris-ray-zhang
force-pushed
the
chris/fixanyscaletemplateutmtracking
branch
from
84f8aa5 to
1a3e6f5
Compare
GeneDer
approved these changes
Feb 5, 2025
| @@ -9,7 +9,10 @@ | |||
| "source": [ | |||
| "# Image Classification Batch Inference with PyTorch\n", | |||
| "\n", | |||
| "[](https://www.anyscale.com/ray-on-anyscale?utm_source=ray_docs&utm_medium=docs&utm_campaign=image-classification-batch-inference-with-pytorch&redirectTo=/v2/template-preview/ray-data-batch-image-classification)\n", | |||
| "<a href=\"https://www.anyscale.com/ray-on-anyscale?utm_source=ray_docs&utm_source=ray_docs&utm_medium=docs&utm_campaign=image-classification-batch-inference-with-pytorch&redirectTo=/v2/template-preview/ray-data-batch-image-classification\">\n", | |||
There was a problem hiding this comment.
utm_source=ray_docs is repeated twice 🙃, but I guess it doesn't affect the functionality
There was a problem hiding this comment.
good call out. thanks. fixed
Signed-off-by: Chris Zhang <[email protected]>
Signed-off-by: Chris Zhang <[email protected]>
chris-ray-zhang
force-pushed
the
chris/fixanyscaletemplateutmtracking
branch
from
42b5d2d to
80ab392
Compare
pcmoritz
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified fixes locally:
Why are these changes needed?
Markdown URLs with "&" incorrectly rendered to "&", which is breaking utm tracking
e.g. Clicking on "Run quickstart" on https://docs.ray.io/en/latest/data/examples/pytorch_resnet_batch_prediction.html renders "https://www.anyscale.com/ray-on-anyscale?utm_source=ray_docs&utm_medium=docs&utm_campaign=image-classification-batch-inference-with-pytorch&redirectTo=/v2/template-preview/ray-data-batch-image-classification"
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.