[Data] Replace number of bundles with proper number of blocks #58030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a good step towards making block counting more accurate by explicitly using the number of blocks instead of assuming one block per bundle. The refactoring is applied across many files. However, I've found a few critical issues where the new counting logic is implemented incorrectly, which could lead to bugs in metrics, backpressure, and autoscaling. I've also included some minor suggestions for improving code style and efficiency.
python/ray/data/_internal/execution/operators/union_operator.py
Outdated
Show resolved
Hide resolved
.../ray/data/_internal/execution/backpressure_policy/downstream_capacity_backpressure_policy.py
Show resolved
Hide resolved
python/ray/data/_internal/execution/operators/base_physical_operator.py
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…bundle Signed-off-by: Alexey Kudinkin <[email protected]>
… num bytes held inside internal queue; Revisited `InternalQueueOperatorMixin.internal_queue_size` to remove assumption that every bundle holds just 1 block Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
Signed-off-by: Alexey Kudinkin <[email protected]>
alexeykudinkin
force-pushed
the
ak/bndl-blk-fix
branch
from
bb87078 to
ea982b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we implicitly assume that
RefBundleholds exactly 1 block. That's not a safe assumption, and this change is addressing that by explicitly referring to number of blocks insteadRelated issues
Additional information