Skip to content

Fix typo in plasma_protocol. - #764

Merged
robertnishihara merged 1 commit into
ray-project:masterfrom
Yeolar:fixtypo
Jul 23, 2017
Merged

robertnishihara merged 1 commit into
ray-project:masterfrom
Yeolar:fixtypo

Conversation

@Yeolar

@Yeolar Yeolar commented Jul 22, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@pcmoritz

Copy link
Copy Markdown
Contributor

ok to test

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/1380/
Test PASSed.

@robertnishihara robertnishihara changed the title fixtypo: plasma_protocol Fix typo in plasma_protocol. Jul 23, 2017
@robertnishihara
robertnishihara merged commit 31329d4 into ray-project:master Jul 23, 2017
@robertnishihara

Copy link
Copy Markdown
Collaborator

Good catch @Yeolar! We've actually moved a lot of this code into the Apache Arrow project, and are in the process of removing it from the Ray codebase and using only the copy in Arrow.

Would you be interested in submitting the same pull request to the Arrow project? I'm happy to do it as well. The relevant file is https://github.com/apache/arrow/blob/master/cpp/src/plasma/protocol.cc.

@Yeolar

Yeolar commented Jul 23, 2017

Copy link
Copy Markdown
Contributor Author

OK, I've submitted a pull request: apache/arrow#878 @robertnishihara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants