Skip to content

Support device name for audio device selection #19995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshmedeski
Copy link
Contributor

Description

My audio device IDs change over time, so the quicklink feature is unreliable. I adjusted the way quicklink generation and connecting work so it can read the device name (which doesn't change).

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: audio-device Issues related to the audio-device extension labels Jun 23, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Jun 23, 2025

Thank you for your contribution! 🎉

🔔 @benvp @mathieudutour @mike182uk @FezVrasta @rcruzper @thomaspaulmann @arthur-fontaine @pernielsentikaer @taschaub @cballenar you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhanced audio device quicklinks to use device names instead of IDs for more reliable device selection, addressing the issue of changing device IDs.

  • Added device name support in extensions/audio-device/src/helpers.tsx for more persistent audio device identification
  • Modified set-output-device.tsx and set-input-device.tsx to support both ID and name-based device lookups
  • New CHANGELOG.md entry needs to follow established format [Update] - {PR_MERGE_DATE} for consistency

4 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: audio-device Issues related to the audio-device extension extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants