Capture all signals and improve code#2
Merged
rciorba merged 3 commits intorciorba:masterfrom Jun 26, 2016
dasJ:master
Merged
Conversation
Owner
|
Hi! Thanks for taking the time to put this together. A few questions, is there a reason for handling the duplicate signals? I preferred documenting the duplication in the comments. Also, for the comment about SIGCHLD which you removed, I just realized I mistakenly say I should not proxy it, but still do. I need to write some tests for that, but the behaviour seems bad. This is mostly a note to self, but thanks for helping me see it :) P.S. Sorry for the slow response, i've been somewhat busy these days |
Contributor
Author
Owner
|
Super! Just drop 7250071 and i'll merge this in. Thanks, |
Contributor
Author
|
Commit is removed 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
I think this is mostly what #1 does, but it does not break the tests.