Skip to content

Capture all signals and improve code#2

Merged
rciorba merged 3 commits intorciorba:masterfrom
dasJ:master
Jun 26, 2016
Merged

Capture all signals and improve code#2
rciorba merged 3 commits intorciorba:masterfrom
dasJ:master

Conversation

@dasJ
Copy link
Contributor

@dasJ dasJ commented Jun 5, 2016

Changes:

  • Catch all signals
  • Only run gcc when target is not up to date
  • Fix some minor code style issues
  • Reformat all debug output

I think this is mostly what #1 does, but it does not break the tests.

@rciorba
Copy link
Owner

rciorba commented Jun 8, 2016

Hi! Thanks for taking the time to put this together.

A few questions, is there a reason for handling the duplicate signals? I preferred documenting the duplication in the comments.

Also, for the comment about SIGCHLD which you removed, I just realized I mistakenly say I should not proxy it, but still do. I need to write some tests for that, but the behaviour seems bad. This is mostly a note to self, but thanks for helping me see it :)

P.S. Sorry for the slow response, i've been somewhat busy these days

@dasJ
Copy link
Contributor Author

dasJ commented Jun 22, 2016

Well I expected #1 to be good and just lacking the tests. So I did basically the same but with tests. If you want me to rebase out 7250071 to merge this, I can do so.

@rciorba
Copy link
Owner

rciorba commented Jun 22, 2016

Super! Just drop 7250071 and i'll merge this in.

Thanks,
R.

@dasJ
Copy link
Contributor Author

dasJ commented Jun 26, 2016

Commit is removed 👍

@rciorba rciorba merged commit 97c5178 into rciorba:master Jun 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants