Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw_touch() feature to also return pressure and timing data #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gitcnd
Copy link

@gitcnd gitcnd commented Aug 2, 2024

Thanks a million for your awesome work.

I want to have "sliders", so I needed more than just "touch event detection", plus my board issues spurious events occasionally, so I've updated the touch-driver to return all the data needed to solve all my problems.

This update makes debounce and spurious-event-rejection possible, and allows polling for when we want to let users "drag things around" (in my case - it's a light-dimmer with an icon of a DJ slider control which they can move around).

This is also a test of whether or not PRs get merged. I'm planning a big update to the graphics code so we can use "rotate" properly (so you specify what rotation to use during init, and all graphics work on that orientation from then on). I'm not sure whether to contribute these new features (a lot of work), or to just do a local version for myself (so I can skip doing the ones I do not need - like polygons etc). No point doing lots of work if nobody wants it of course...

…ng debounce and spurious-event-rejection possible
@rdagger
Copy link
Owner

rdagger commented Aug 3, 2024

Thanks for the effort you've put into enhancing the functionality! Your work could significantly benefit users. However, I don’t normally accept pull requests unless they are bug fixes or minor non-breaking updates.

I believe that maintaining your changes in a separate branch would be the most appropriate. Given my current time constraints, having a dedicated branch for this specific implementation will help ensure that the core project remains easily maintainable while still offering this advanced option for users who need it.

I’d be happy to add a link to your project from my repo to direct users to your work.

gitcnd added 2 commits August 8, 2024 23:40
…24, and recipe to make themImproved clock/time and file date handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants