improved packaging, geometry export, and spline support#29
Merged
Conversation
added 5 commits
October 23, 2025 13:57
…pers with a default field and - carry layer assignments through geometry JSON and package creation - add layer-aware toggles and scaled grid/labels in ycpkg viewer (3D & 2D) - annotate rocket/example8 packages with meaningful layers - document the new layer conventions and update layer-aware tests
- ensure metadata roots default to a `layer` and add `set_layer` helper - propagate layer metadata through geometry JSON, packaging helpers, and examples - teach the viewer to group entities by layer with toggles and readable help overlays (H/F1) - fix scroll direction, overlay rendering (with depth-safe state push/pop), and DXF/package examples - document the layer field and update tests for layer serialization & package output
…export - serialize sketch primitives (line, arc, circle, Catmull-Rom, NURBS, polyline) alongside sampled polylines so round- tripping retains parametric fidelity - rehydrate those primitives in geometry_from_json and teach bbox utilities about them - update DXF exporter to consume the stored primitives, emit native CIRCLE/ARC entities, and generate closed LWPOLYLINEs for closed splines - add an end-to-end spline extrusion package test to validate viewing and DXF/STEP export - document the new sketch primitives field in the package spec
- Correct pole triangle winding in makeRevolutionSurface so end caps face outward - Add regression test ensuring revolved surfaces report proper cap normals - Rebuild maintained assets via pytest guard to catch regressions early
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull merges in big improvements in yapCAD package functionality and geometry export, and extends extrusion support to include shapes defined by splines. There are enhancements to command line tools and significant documentation updates. An involute gear generation example was added based on the MIT-licensed figgear repo