Conversation
Design document for beam segmentation framework enabling 3D printing of parts that exceed build volume. Covers: - Interior connector approach for hollow swept elements - Cut point computation and connector design - Press-fit tolerances for FDM printing - API design with segment_swept_element() and create_interior_connector() - DSL integration proposals - 5-phase implementation roadmap - Specific globe stand example (12 printable segments) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The globe stand also has a top ring that holds the globe. Added it to the analysis with note that it may fit within build volume without segmentation due to its smaller diameter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
…xes for normal direction in oriented BREP surfaces
- Fix ParserError typo (was ParseError) in while loop deprecation handler - Fix ParserError construction to use Diagnostic object properly - Add TYPE_CHECKING import for PackageManifest in packaging.py - Add test for while loop deprecation error in test_dsl_parser.py - Add new test_dsl_packaging.py with 17 tests covering PackageResult, package_from_dsl, and helper functions Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add TYPE_CHECKING import block for ConnectorSpec and SweptElementProvenance forward references. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…shes The native boolean engine produces non-manifold meshes (T-junctions and open boundaries) for difference and intersection operations. These tests require closed manifolds for volumeof() to work correctly. Tests are now skipped when: - YAPCAD_BOOLEAN_ENGINE=native is set - OCC is not available (CI environment) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Owner
Author
|
Rejected due to CI test failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes, addition of manufacturing post-processing plan document and initial implementation.