Skip to content

fix(TextBox): update Text patching to allow for proper dimension setting and text centering #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

fix(TextBox): update Text patching to allow for proper dimension setting and text centering #463

wants to merge 3 commits into from

Conversation

ImCoolNowRight
Copy link
Contributor

Description

This PR updates how the patch object for the Text tag is created to ensure the tag can get the proper parent dimensions it needs in order to center text.

References

LUI-1324

Testing

In the TextBox story, add textAlign: 'center' to the textStyle. You should see that the text properly centers when you toggle the control for fixed.

Automation

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@joshhowenstine joshhowenstine added the WIP In progress but could use an initial review label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erautenberg erautenberg Awaiting requested review from erautenberg erautenberg will be requested when the pull request is marked ready for review erautenberg is a code owner

@anthony9187 anthony9187 Awaiting requested review from anthony9187 anthony9187 will be requested when the pull request is marked ready for review anthony9187 is a code owner

@ctoddy ctoddy Awaiting requested review from ctoddy ctoddy will be requested when the pull request is marked ready for review ctoddy is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
WIP In progress but could use an initial review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImCoolNowRight @svc-lightning-ui-components @joshhowenstine