RDKB-58244: SMApp update based on status of the Mesh.Enable and HCM #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivianecordeiro-sky
requested changes
Mar 11, 2025
I can't see the comments |
HollowMax
force-pushed
the
fix_mesh_disabled
branch
from
710da57 to
396b90f
Compare
HollowMax
force-pushed
the
fix_mesh_disabled
branch
from
271c4be to
4736e4e
Compare
|
@HollowMax |
HollowMax
force-pushed
the
fix_mesh_disabled
branch
from
4736e4e to
58d34c4
Compare
|
Hi @gsathish86 resolved the conflicts, updated the code base, also Viviane's comments were addressed. |
|
|
HollowMax
force-pushed
the
fix_mesh_disabled
branch
from
84a5d4d to
0e227e6
Compare
|
All contributors have signed the CLA ✍️ ✅ |
HollowMax
force-pushed
the
fix_mesh_disabled
branch
from
0e227e6 to
dadc0a0
Compare
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
|
@gsathish86 can you please tell me if I need to do something else for merge? |
gsathish86
reviewed
Sep 15, 2025
gsathish86
requested changes
Sep 15, 2025
Reason for change: SMApp continues to run when Mesh is disabled.
Test Procedure: 1. Disable getv Device.DeviceInfo.X_RDKCENTRAL-COM_xOpsDeviceMgmt.Mesh.Enable and Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.MeshWifiOptimization.Mode
2. Check if SM_APP is still running.
Risks: Low
Priority: P2
Signed-off-by: Maksym Holovatyi <[email protected]>
HollowMax
force-pushed
the
fix_mesh_disabled
branch
from
3e299ff to
192564c
Compare
gsathish86
approved these changes
Sep 15, 2025
vivianecordeiro-sky
approved these changes
Sep 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: SMApp continues to run when Mesh is disabled.
Test Procedure:
Risks: Low
Priority: P2