RDKB-59707: Fixing audit comments #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
All contributors have signed the CLA ✍️ ✅ |
Pavlo-Uvarov
force-pushed
the
RDKB-59707-fix-comments
branch
from
f60d7b7 to
040b717
Compare
|
I have read the CLA Document and I hereby sign the CLA |
Pavlo-Uvarov
force-pushed
the
RDKB-59707-fix-comments
branch
5 times, most recently
from
222a543 to
0d3c4d7
Compare
Reason for change: Added Comcast copyright to NOTICE according to OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Changed license file name according to OneWifi audit. Test procedure: - Risks: Low Priority: P1
Pavlo-Uvarov
force-pushed
the
RDKB-59707-fix-comments
branch
from
0d3c4d7 to
e5e8690
Compare
Reason for change: Removind BCM string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind CGA4 string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind CGM4 string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind DPC string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind TG1 string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind TG4 string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind WNX string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind X50 string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind XB3 string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Removind XF3 string literals according with OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Added missing license headers according to OneWifi audit. Test procedure: - Risks: Low Priority: P1
Reason for change: Replaced configparamgen and sensitive token with usage of GetConfigFile Test procedure: - Risks: Low Priority: P1
Pavlo-Uvarov
force-pushed
the
RDKB-59707-fix-comments
branch
from
e5e8690 to
035b9f5
Compare
narendradandu
approved these changes
Sep 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixed comments from OneWifi audit.
Test Procedure: -
Risks: Low
Priority: P1
Signed-off-by: [email protected]