Skip to content

RDKEMW-2866 : Update to bring in line with guideline #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-2866 : Update to bring in line with guideline #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
793c51f
RDKEMW-2866 : Update to bring in line with guideline
hgfell683 Jun 5, 2025
cf01edd
RDKEMW-2866 : Update to bring in line with guideline
hgfell683 Jun 5, 2025
c39bc4a
Merge pull request #265 from rdkcentral/develop
hgfell683 Jun 11, 2025
b22d361
Merge pull request #274 from rdkcentral/develop
hgfell683 Jun 12, 2025
46da18c
Merge pull request #300 from rdkcentral/develop
hgfell683 Jun 18, 2025
ab9675b
Merge pull request #447 from rdkcentral/develop
hgfell683 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/DisplayInfo/IConfiguration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Exchange {
struct EXTERNAL IConfiguration : virtual public Core::IUnknown {
enum { ID = ID_CONFIGURATION };

virtual uint32_t Configure(PluginHost::IShell* framework) = 0;
virtual Core::hresult Configure(PluginHost::IShell* framework) = 0;
};
}
}
Expand Down
50 changes: 25 additions & 25 deletions apis/DisplayInfo/IDisplayInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,20 +32,20 @@ namespace Exchange {
// @property
// @brief Total GPU DRAM memory (in bytes)
// @return total: Total GPU RAM
virtual uint32_t TotalGpuRam(uint64_t& total /* @out */) const = 0;
virtual Core::hresult TotalGpuRam(uint64_t& total /* @out */) const = 0;

// @property
// @brief Free GPU DRAM memory (in bytes)
// @return free: Free GPU RAM
virtual uint32_t FreeGpuRam(uint64_t& free /* @out */) const = 0;
virtual Core::hresult FreeGpuRam(uint64_t& free /* @out */) const = 0;
};

/* @json @uncompliant:extended */ // NOTE: extended format is deprecated!! Do not just copy this line!
struct EXTERNAL IConnectionProperties : virtual public Core::IUnknown {
enum { ID = ID_CONNECTION_PROPERTIES };

enum HDCPProtectionType : uint8_t {
HDCP_Unencrypted,
HDCP_UNENCRYPTED,
HDCP_1X,
HDCP_2X,
HDCP_AUTO
Expand All @@ -65,56 +65,56 @@ namespace Exchange {
virtual void Updated(const Source event) = 0;
};

virtual uint32_t Register(INotification*) = 0;
virtual uint32_t Unregister(INotification*) = 0;
virtual Core::hresult Register(INotification*) = 0;
virtual Core::hresult Unregister(INotification*) = 0;

// @property
// @brief Current audio passthrough status on HDMI
// @param passthru: enabled/disabled
virtual uint32_t IsAudioPassthrough (bool& passthru /* @out */) const = 0;
virtual Core::hresult IsAudioPassthrough (bool& passthru /* @out */) const = 0;

// @property
// @brief Current HDMI connection status
// @param isconnected: connected/disconnected
virtual uint32_t Connected(bool& isconnected /* @out */) const = 0;
virtual Core::hresult Connected(bool& isconnected /* @out */) const = 0;

// @property
// @brief Horizontal resolution of TV
// @param width: width of TV in pixels
virtual uint32_t Width(uint32_t& width /* @out */) const = 0;
virtual Core::hresult Width(uint32_t& width /* @out */) const = 0;

// @property
// @brief Vertical resolution of TV
// @param height: height of TV in pixels
virtual uint32_t Height(uint32_t& height /* @out */) const = 0;
virtual Core::hresult Height(uint32_t& height /* @out */) const = 0;

// @property
// @brief Vertical Frequency
// @param vf: vertical freq
virtual uint32_t VerticalFreq(uint32_t& vf /* @out */) const = 0;
virtual Core::hresult VerticalFreq(uint32_t& vf /* @out */) const = 0;

// @brief TV's Extended Display Identification Data
// @param edid: edid byte string
virtual uint32_t EDID (uint16_t& length /* @inout */, uint8_t data[] /* @out @length:length */) const = 0;
virtual Core::hresult EDID (uint16_t& length /* @inout */, uint8_t data[] /* @out @length:length */) const = 0;

// @brief Horizontal size in centimeters
// @param width: width in cm
virtual uint32_t WidthInCentimeters(uint8_t& width /* @out */) const = 0;
virtual Core::hresult WidthInCentimeters(uint8_t& width /* @out */) const = 0;

// @brief Vertical size in centimeters
// @param width: height in cm
virtual uint32_t HeightInCentimeters(uint8_t& height /* @out */) const = 0;
virtual Core::hresult HeightInCentimeters(uint8_t& height /* @out */) const = 0;

// @property
// @brief HDCP protocol used for transmission
// @param value: protocol
virtual uint32_t HDCPProtection (HDCPProtectionType& value /* @out */) const = 0;
virtual uint32_t HDCPProtection (const HDCPProtectionType value) = 0;
virtual Core::hresult HDCPProtection (HDCPProtectionType& value /* @out */) const = 0;
virtual Core::hresult HDCPProtection (const HDCPProtectionType value) = 0;

// @property
// @brief Video output port on the STB used for connection to TV
// @param name: video output port name
virtual uint32_t PortName (string& name /* @out */) const = 0;
virtual Core::hresult PortName (string& name /* @out */) const = 0;

};

Expand All @@ -137,17 +137,17 @@ namespace Exchange {
// @property
// @brief HDR formats supported by TV
// @return HDRType: array of HDR formats
virtual uint32_t TVCapabilities(IHDRIterator*& type /* @out */) const = 0;
virtual Core::hresult TVCapabilities(IHDRIterator*& type /* @out */) const = 0;

// @property
// @brief HDR formats supported by STB
// @return HDRType: array of HDR formats
virtual uint32_t STBCapabilities(IHDRIterator*& type /* @out */) const = 0;
virtual Core::hresult STBCapabilities(IHDRIterator*& type /* @out */) const = 0;

// @property
// @brief HDR format in use
// @param type: HDR format
virtual uint32_t HDRSetting(HDRType& type /* @out */) const = 0;
virtual Core::hresult HDRSetting(HDRType& type /* @out */) const = 0;
};

/* @json */
Expand Down Expand Up @@ -219,32 +219,32 @@ namespace Exchange {
// @property
// @brief Provides access to the display's Colour space (chroma subsampling format)
// @param cs: colour space
virtual uint32_t ColorSpace(ColourSpaceType& cs /* @out */) const = 0;
virtual Core::hresult ColorSpace(ColourSpaceType& cs /* @out */) const = 0;

// @property
// @brief Provides access to Frame Rate
// @param rate: frame rate
virtual uint32_t FrameRate(FrameRateType& rate /* @out */) const = 0;
virtual Core::hresult FrameRate(FrameRateType& rate /* @out */) const = 0;

// @property
// @brief Provides access to display's colour Depth
// @param colour: colour depth
virtual uint32_t ColourDepth(ColourDepthType& colour /* @out */) const = 0;
virtual Core::hresult ColourDepth(ColourDepthType& colour /* @out */) const = 0;

// @property
// @brief Provides access to display's colorimetry
// @param colorimetry: display colorimetry
virtual uint32_t Colorimetry(IColorimetryIterator*& colorimetry /* @out */) const = 0;
virtual Core::hresult Colorimetry(IColorimetryIterator*& colorimetry /* @out */) const = 0;

// @property
// @brief Provides access to display's Qauntization Range
// @param qr: quantization range
virtual uint32_t QuantizationRange(QuantizationRangeType& qr /* @out */) const = 0;
virtual Core::hresult QuantizationRange(QuantizationRangeType& qr /* @out */) const = 0;

// @property
// @brief Provides access to display's Electro optical transfer function
// @param eotf: display's EOTF
virtual uint32_t EOTF(EotfType& eotf /* @out */) const = 0;
virtual Core::hresult EOTF(EotfType& eotf /* @out */) const = 0;
};
}
}
Loading