TEST: Update IHdcpProfile.h #644
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request attempts to rename the GetHDCPStatus method to getHDCPStatus in the IHdcpProfile interface header. However, this change violates the established naming conventions for RDK Entertainment Services APIs, which require interface methods to use PascalCase while the JSON-RPC mapping (defined via @text annotations) uses camelCase.
Key Changes
- Attempted rename of
GetHDCPStatusmethod togetHDCPStatus(incorrect - violates naming convention)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // @param HDCPStatus: Contains HDCP-related data as separate properties | ||
| // @param success: Indicates whether the operation was successful | ||
| virtual Core::hresult GetHDCPStatus(HDCPStatus& hdcpStatus /* @out @text HDCPStatus*/,bool& success /* @out */) = 0; | ||
| virtual Core::hresult getHDCPStatus(HDCPStatus& hdcpStatus /* @out @text HDCPStatus*/,bool& success /* @out */) = 0; |
There was a problem hiding this comment.
Method name violates naming convention. Interface method names MUST use PascalCase, not camelCase. The method should be named GetHDCPStatus (with capital 'G'), not getHDCPStatus. The camelCase variant is only for the JSON-RPC mapping defined via the @text annotation.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RUNNING = 0 /* @text running */, | ||
| STOPPED = 1/* @text stopped */, | ||
| HIDDEN = 2 /* @text suspended */ | ||
| HIDDEn = 2 /* @text suspended */ |
There was a problem hiding this comment.
Enum names MUST be in ALL_UPPER_SNAKE_CASE. The enum value name "HIDDEn" contains a lowercase 'n' which violates the naming convention. It should be "HIDDEN" (all uppercase).
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // @param strQuery: Query string to be appended in launch request | ||
| // @param strAddDataUrl: Additional data URL to be passed to the application | ||
| virtual void OnApplicationLaunchRequestWithParam(const string& appName /* @text applicationName */ , const string& strPayLoad /* @text strPayLoad */, const string& strQuery /* @text strQuery */, const string& strAddDataUrl /* @text strAddDataUrl */) {}; | ||
| virtual void ONApplicationLaunchRequestWithParam(const string& appName /* @text applicationName */ , const string& strPayLoad /* @text strPayLoad */, const string& strQuery /* @text strQuery */, const string& strAddDataUrl /* @text strAddDataUrl */) {}; |
There was a problem hiding this comment.
Event method name ONApplicationLaunchRequestWithParam has incorrect capitalization. Event method names in interface headers should be in PascalCase according to the coding guidelines. This should be OnApplicationLaunchRequestWithParam (with lowercase 'n' after 'O').
No description provided.