RDK-56276: Add user settings inspector interface to user settings plugin #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramasat
reviewed
Mar 19, 2025
| | result.deviceInfo[#]?.productInfo4?.serialNumber | string | <sup>*(optional)*</sup> Unicode string representing the serial number of the device | | ||
| | result.deviceInfo[#]?.productInfo4?.manufacturer | string | <sup>*(optional)*</sup> Unicode string representing the manufacturer of the device | | ||
| | result.deviceInfo[#]?.productInfo4?.product | string | <sup>*(optional)*</sup> Unicode string representing the product | | ||
| | result | array | An array of USBDeviceInfo | |
There was a problem hiding this comment.
Not sure, why this needs to be an array. Can you please check the code?
| | result[#]?.productInfo4 | object | <sup>*(optional)*</sup> | | ||
| | result[#]?.productInfo4?.languageId | integer | <sup>*(optional)*</sup> Language ID present on the device | | ||
| | result[#]?.productInfo4?.serialNumber | string | <sup>*(optional)*</sup> Unicode string representing the serial number of the device | | ||
| | result[#]?.productInfo4?.manufacturer | string | <sup>*(optional)*</sup> Unicode string representing the manufacturer of the device | |
There was a problem hiding this comment.
There can and will always be 4 entries in the product info?
| | partitionName | string | The name of the partition being mounted | | ||
| | mountFlags | string | Flags indicating how the partition is mounted | | ||
| | mountPath | string | The mount point path in the file system | | ||
| | params.mountPoints | array | mount info list of a USB storage device will be returned | |
There was a problem hiding this comment.
This is not matching the spec. The spec says we also carry device info. Why was it omitted here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Added user settings inspector documentation and USB plugins documentation updates.
Risks: Low
Priority: P1
Signed-off-by: [email protected]