Update by hgfell683 · Pull Request #104 · rdkcentral/entservices-peripherals

hgfell683 · 2025-09-18T15:00:31Z

No description provided.

* RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 - COMRPC for FrontPanel * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC * RDKEMW-1013 FrontPanel COMRPC

1.0.12 release 1.0.12

CLAassistant · 2025-09-18T15:00:38Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ arun-madhavan-013
✅ hgfell683
✅ Alan-Ryan
❌ actions-user
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…interface header changes (#93) * RDKEMW-3789: align to ILEDControl changes * RDKEMW-3789: LEDControl resolve the build errors * RDKEMW-3789: fix the build error * RDKEMW-3789: optimize the code and update proper return values * RDKEMW-3789: change error to proper value * RDKEMW-3789: add debug logs to clarify mismatching state * RDKEMW-3789: clean-up test logic and make the plugin singleton and inhibit copying or multiple instantiations * RDKEMW-3789: enhance LEDControl implementation with cache for supported state * RDKEMW-3789: LEDControl return unsupported if HAL init fails * RDKEMW-3789: add backward compatibility for GetLEDState * RDKEMW-3789: LEDControl align the ERROR response to previous behavior * RDKEMW-3789: LEDControl add logging to confirm method triggered * RDKEMW-3789: fix the build issues * RDKEMW-3789: fix the L2 compile error * RDKEMW-3789: unwanted remove editor configs * RDKEMW-3789: update LEDControl L2 COMRPC states to matching states * RDKEMW-3789: point testframework to fetch the updated code * RDKEMW-3789: Turn OFF LEDControl L2 for unblocking others * RDKEMW-3789: turn OFF L2 of LEDControl until testframework adopts the change * RDKEMW-3789: LEDControl implement L2 changes * RDKEMW-3789: use testframework SHA for workflow verification * RDKEMW-3789: LEDControl add the missing conversions * RDKEMW-3789: LEDControl L2 revert to old logic * RDKEMW-3789: LEDControl L2 fix the logical issues * RDKEMW-3789: LEDcontrol L2 correct the enum used * RDKEMW-3789: LEDControl L2 fix the error * RDKEMW-3789: LEDControl L2 enhancements * RDKEMW-3789: LEDControl fix the duplicate TC definition and warning * RDKEMW-3789: LEDControl L2 fix warnings and correct init param * RDKEMW-3789: LEDControl L2 fix the error code mismatches * RDKEMW-3789: use updated testframework * RDKEMW-3789: Update L1-tests to use default develop head * RDKEMW-3789: Update L2-tests to use default develop head

1.0.13 release 1.0.13

Deploy cla action

1.0.14 release 1.0.14

Deploy fossid_integration_stateless_diffscan_target_repo action

1.0.15 release 1.0.15

* RDKEMW-7784 - Frontpanel GTest --------- Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>

1.0.16 release 1.0.16

* RDKEMW-7617 - Range in 'getFrontPanelLights' api * RDKEMW-7617 - Range in 'getFrontPanelLights' api

1.0.17 release 1.0.17

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Reason for change: README update Test Procedure: None Risks: Low Priority: P1 version: patch

1.5.1 release 1.5.1

Copilot

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

…cecontrol to MW builds (#134) * Removing voice and remote control plugins. * Adding temp dummy target when there are no cmake install targets * Updates

RDKEMW-12197: Remove entservices-remotecontrol and entservices-voicecontrol

Copilot

Pull request overview

Copilot reviewed 65 out of 65 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (4)

helpers/frontpanel.cpp:1

CFrontPanel::deinitialize() dereferences s_instance unconditionally (s_instance->stop()), which will crash if deinitialize() is called before instance() initializes the singleton (or after it has already been deleted). Guard s_instance before calling stop() (and ideally make deinitialize() idempotent so repeated calls are safe).
helpers/frontpanel.h:1
CFrontPanel::loadPreferences() remains part of the public helper API, but its implementation was removed in helpers/frontpanel.cpp in this PR. If any remaining code links against this helper and calls loadPreferences(), it will fail at link time with an undefined reference. Either restore the implementation, or remove/replace this API (and any callers) as part of the same change.
helpers/PluginInterfaceBuilder.h:1
The move constructor transfers _service from other, but it only nulls other._interface and leaves other._service intact. If the moved-from object later tries to use/release _service (e.g., in a destructor or another method), this can lead to double-release or unexpected behavior. Consider setting other._service = nullptr (and ensure move assignment, destructor, and ownership semantics are consistent).
README.md:1
The Markdown table uses double leading pipes (||), which renders as an extra empty column in many Markdown parsers. Use single leading pipes (|) per row for a standard 2-column table.

* Add FindTelemetry.cmake to locate Telemetry library * Integrate Telemetry package in CMakeLists.txt Added Telemetry package support to MotionDetection plugin. * Add telemetry bus message sender include

Signed-off-by: svemur170 <srikanth_vemuri@comcast.com>

1.6.1 for develop

Copilot

Pull request overview

Copilot reviewed 67 out of 67 changed files in this pull request and generated 5 comments.

Copilot · 2026-03-12T02:05:04Z

+        void CFrontPanel::deinitialize()
+        {
+
+            s_instance->stop();
+


CFrontPanel::deinitialize() dereferences s_instance unconditionally (s_instance->stop()), which will crash if deinitialize is called before instance() initializes s_instance (or after it was already deleted). Add a null check (and ideally an initDone guard) before calling methods on s_instance, and consider making the function idempotent so repeated calls are safe.

Copilot · 2026-03-12T02:05:05Z

            void setPowerStatus(bool powerStatus);
-            JsonObject getPreferences();
-            void setPreferences(const JsonObject& preferences);
            bool setLED(const JsonObject& blinkInfo);
            void setBlink(const JsonObject& blinkInfo);
            void loadPreferences();
            void stopBlinkTimer();


CFrontPanel still declares loadPreferences() as a public method, but there is no corresponding definition in the repo (searching for CFrontPanel::loadPreferences returns nothing). This will lead to link errors for any target that links helpers/frontpanel.cpp and calls this API; either restore the implementation or remove the declaration if it’s intentionally no longer supported.

Copilot · 2026-03-12T02:05:05Z

        // use move
        PluginInterfaceRef(PluginInterfaceRef&& other)
            : _interface(other._interface)
+            , _service(other._service)
        {
            other._interface = nullptr;
        }


PluginInterfaceRef now stores _service and moves it in the move-constructor, but the move-constructor only nulls other._interface (not other._service). More importantly, move-assignment/other operations should be updated to treat _service consistently (move it and clear the moved-from state) to avoid stale pointers and confusing object state.

Copilot · 2026-03-12T02:05:05Z

 #include <syscall.h>
 #include "UtilsJsonRpc.h"

+#include <telemetry_busmessage_sender.h>
+


Telemetry is included and used unconditionally (#include <telemetry_busmessage_sender.h>), but the CMake changes make Telemetry optional (find_package(Telemetry) + link only when found). If Telemetry isn't installed, this will fail to compile even though TELEMETRY_FOUND is false. Please guard the include/usage behind a compile definition (e.g., ENABLE_TELEMETRY_LOGGING) or make Telemetry a required dependency for MotionDetection.

Copilot · 2026-03-12T02:05:05Z

 find_package(${NAMESPACE}Plugins REQUIRED)
+find_package(Telemetry)

 add_library(${MODULE_NAME} SHARED


find_package(Telemetry) is optional here, but MotionDetection.cpp includes and calls telemetry APIs unconditionally. Either make Telemetry REQUIRED in CMake, or add a compile definition when TELEMETRY_FOUND is true and conditionally compile telemetry-related code so builds without Telemetry still succeed.

github-advanced-security · 2026-05-21T09:06:01Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

* RDKEMW-18857 : Remove RDKCM_RDKE from all workflows Reason for change: RDKCM_RDKE secret is introduced to access entservices-testframework when its private. Now repo has been made as public. So, removing the RDKCM_RDKE secrets from all workflows. Test Procedure: refer ticket. Risks: Medium Priority: P2 version: Patch Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com> * Update component-release.yml * Update build_dependencies.sh * Update component-release.yml * Updated component-release-main.yml --------- Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com> Co-authored-by: balaji velmurugan <balaji_velmurugan@comcast.com> Co-authored-by: rajaLucy <rajakiranyadavalli@gmail.com>

Copilot

Pull request overview

Copilot reviewed 70 out of 70 changed files in this pull request and generated 5 comments.


+#include <telemetry_busmessage_sender.h>
+


+if(TELEMETRY_FOUND)
+    target_link_libraries(${MODULE_NAME} PRIVATE ${TELEMETRY_LIBRARIES})
+    target_include_directories(${MODULE_NAME} PRIVATE ${TELEMETRY_INCLUDE_DIRS})
+endif()


+find_package(PkgConfig)
+
+find_library(TELEMETRY_LIBRARIES NAMES telemetry_msgsender)
+find_path(TELEMETRY_INCLUDE_DIRS NAMES telemetry_busmessage_sender.h)
+
+include(FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(TELEMETRY DEFAULT_MSG TELEMETRY_INCLUDE_DIRS TELEMETRY_LIBRARIES)
+
+mark_as_advanced(
+    TELEMETRY_FOUND
+    TELEMETRY_INCLUDE_DIRS
+    TELEMETRY_LIBRARIES)


+        void CFrontPanel::deinitialize()
+        {
+
+            s_instance->stop();
+
+            if (_powerManagerPlugin) {
+                _powerManagerPlugin.Reset();
+            }
+            if (s_instance) {
+                delete s_instance;
+                s_instance = nullptr;
+            }
+            initDone = 0;
+        }


+			t2_event_d("SYST_INFO_NotifyMotion", 1);
+


Co-authored-by: smohap466_comcast <srinibas_mohapatra@comcast.com>

Copilot

Pull request overview

Copilot reviewed 70 out of 70 changed files in this pull request and generated no new comments.

Suppressed comments (4)

MotionDetection/MotionDetection.cpp:463

This telemetry event is emitted unconditionally. If telemetry logging is disabled (ENABLE_TELEMETRY_LOGGING not defined) or the telemetry library is not linked, this will cause compile/link failures or unintentionally emit telemetry in builds where it’s meant to be off.
MotionDetection/CMakeLists.txt:27
Telemetry is discovered and linked opportunistically, but MotionDetection.cpp currently uses telemetry APIs unconditionally. This combination can break builds when telemetry isn’t present. Consider tying Telemetry discovery/linking to BUILD_ENABLE_TELEMETRY_LOGGING and making it REQUIRED when enabled.
helpers/frontpanel.cpp:216
CFrontPanel::deinitialize() dereferences s_instance unconditionally (s_instance->stop()), which will crash if deinitialize() is called before instance() creates the singleton (or after it has already been deleted).
MotionDetection/MotionDetection.cpp:29
Telemetry is included unconditionally, but the project only enables telemetry via the ENABLE_TELEMETRY_LOGGING define (see helpers/UtilsTelemetry.h). As written, builds without telemetry headers available (or when telemetry is intentionally disabled) can fail at compile/link time.

rdkcmf-jenkins and others added 5 commits June 24, 2025 14:04

Deploy cla action

fbff2b9

1.0.12 release changelog updates

9315eda

Merge tag '1.0.12' into develop

85d77b1

1.0.12 release 1.0.12

Merge branch 'release/1.0.12'

4734afe

hgfell683 requested a review from a team as a code owner September 18, 2025 15:00

arun-madhavan-013 and others added 23 commits September 24, 2025 08:47

1.0.13 release changelog updates

99e644a

Merge tag '1.0.13' into develop

4617dc1

1.0.13 release 1.0.13

Merge branch 'release/1.0.13'

e77d230

Merge branch 'develop' into feature/action-deploy-for/develop

c351b8a

Deploy cla action

feb67ca

Merge pull request #57 from rdkcentral/feature/action-deploy-for/develop

8d44882

Deploy cla action

1.0.14 release changelog updates

919d5f1

Merge tag '1.0.14' into develop

ddc2174

1.0.14 release 1.0.14

Merge branch 'release/1.0.14'

babe1e4

Deploy fossid_integration_stateless_diffscan_target_repo action

a37b5e6

Merge pull request #108 from rdkcentral/feature/actions/develop-fossid

60c6f07

Deploy fossid_integration_stateless_diffscan_target_repo action

1.0.15 release changelog updates

5226065

Merge tag '1.0.15' into develop

5ac2b8d

1.0.15 release 1.0.15

Merge branch 'release/1.0.15'

1714f67

RDKEMW-7784: FrontPanel GTest (#105)

0091579

* RDKEMW-7784 - Frontpanel GTest --------- Co-authored-by: apatel859 <48992974+apatel859@users.noreply.github.com>

1.0.16 release changelog updates

e9150e2

Merge tag '1.0.16' into develop

847dad9

1.0.16 release 1.0.16

Merge branch 'release/1.0.16'

79a9ef7

RDKEMW-7617 - Range in 'getFrontPanelLights' api (#110)

98cb4ff

* RDKEMW-7617 - Range in 'getFrontPanelLights' api * RDKEMW-7617 - Range in 'getFrontPanelLights' api

1.0.17 release changelog updates

65919de

Merge tag '1.0.17' into develop

ed0e01a

1.0.17 release 1.0.17

Merge branch 'release/1.0.17'

f4b1a40

Copilot AI reviewed Feb 27, 2026

srikanth-vv and others added 4 commits February 27, 2026 14:17

RDKEMW-12639 - README update (#139)

c0e30a3

Reason for change: README update Test Procedure: None Risks: Low Priority: P1 version: patch

1.5.1 release changelog updates

8c8bfd7

Merge tag '1.5.1' into develop

a0d25b4

1.5.1 release 1.5.1

Merge branch 'release/1.5.1'

ae5111a

Copilot AI review requested due to automatic review settings February 27, 2026 19:17

Copilot AI reviewed Feb 27, 2026

msmith113 and others added 4 commits March 3, 2026 10:29

RDKEMW-12197: Integrate entservices-remotecontrol and entservices-voi…

bb54d6b

…cecontrol to MW builds (#134) * Removing voice and remote control plugins. * Adding temp dummy target when there are no cmake install targets * Updates

1.6.0 release changelog updates

c81562a

Merge branch 'release/1.6.0'

9dad045

Merge tag '1.6.0' into develop

b321b37

RDKEMW-12197: Remove entservices-remotecontrol and entservices-voicecontrol

Copilot AI review requested due to automatic review settings March 4, 2026 13:07

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Copilot started reviewing on behalf of anand-ky March 4, 2026 13:13 View session

andrejz2 and others added 4 commits March 11, 2026 21:34

Feature/rdk 55825 (#142)

204d08d

* Add FindTelemetry.cmake to locate Telemetry library * Integrate Telemetry package in CMakeLists.txt Added Telemetry package support to MotionDetection plugin. * Add telemetry bus message sender include

RDK-55825 - Changelog updates for 1.6.1

9039d0b

Signed-off-by: svemur170 <srikanth_vemuri@comcast.com>

Merge branch 'release/1.6.1'

c36836c

Merge tag '1.6.1' into develop

7f51d4b

1.6.1 for develop

Copilot AI review requested due to automatic review settings March 12, 2026 01:59

Copilot started reviewing on behalf of srikanth-vv March 12, 2026 02:00 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 9, 2026 16:13

Copilot started reviewing on behalf of srikanth-vv July 9, 2026 16:13 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

RDKEMW-22169 : use 4.0.8 tag of entservices-apis (#147)

be5279b

Co-authored-by: smohap466_comcast <srinibas_mohapatra@comcast.com>

Copilot AI review requested due to automatic review settings August 5, 2026 12:41

Copilot started reviewing on behalf of srikanth-vv August 5, 2026 12:50 View session

Copilot AI reviewed Aug 5, 2026

View reviewed changes

Navigation Menu

Uh oh!

Update - #104

Update#104
hgfell683 wants to merge 86 commits into
feature/RDKEMW-7784from
develop

hgfell683 commented Sep 18, 2025

Uh oh!

CLAassistant commented Sep 18, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

github-advanced-security AI commented May 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

hgfell683 commented Sep 18, 2025

Uh oh!

CLAassistant commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-advanced-security AI commented May 21, 2026

What Enabling Code Scanning Means:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

CLAassistant commented Sep 18, 2025 •

edited

Loading