Add support for COMRPC changes in L2Tests plugin in Testframework repo by smanes0213 · Pull Request #129 · rdkcentral/entservices-peripherals

smanes0213 · 2026-01-05T11:23:44Z

No description provided.

Changed -Wno-deprecated-declarations to -Wno-error=deprecated-declarations to allow warnings from Thunder's VirtualInput.h without failing the build.

Copilot

Pull request overview

This pull request updates the L2Tests plugin in the TestFramework repository to align with COM-RPC (Component Object Model - Remote Procedure Call) best practices. The changes remove an unnecessary manual reference count increment and update workflow configurations to use feature branches for testing the COMRPC changes.

Changes:

Removed manual AddRef() call on interface obtained via QueryInterface() in LedControl_L2Test
Updated workflow references from develop to L2TestPlugin_COMRPC branch for coordinated testing
Fixed CMake build configuration parameter name from BUILD_TYPE to CMAKE_BUILD_TYPE
Updated entservices-apis reference to Test branch for all workflows

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
Tests/L2Tests/tests/LedControl_L2Test.cpp	Removed unnecessary manual `AddRef()` call after `QueryInterface()`, properly aligning with Thunder COM-RPC semantics
.github/workflows/L2-tests.yml	Updated branch references to coordinate testing and fixed CMake parameter name
.github/workflows/L1-tests.yml	Updated branch references to coordinate testing across test workflows

Comments suppressed due to low confidence (1)

Tests/L2Tests/tests/LedControl_L2Test.cpp:138

The QueryInterface() method in Thunder's COM-RPC framework automatically increments the reference count when returning an interface pointer. The removal of the manual AddRef() call is correct and aligns with Thunder COM-RPC best practices. However, ensure that the interface is still properly released in the destructor (which is confirmed at lines 103-105). This change correctly addresses reference counting semantics.

            m_LEDplugin = m_controller_LED->QueryInterface<Exchange::ILEDControl>();

Copilot · 2026-01-15T08:53:31Z

          repository: rdkcentral/entservices-peripherals
          path: entservices-peripherals
-          ref: develop
+          ref: L2TestPlugin_COMRPC


Workflow is using feature branch references (L2TestPlugin_COMRPC and Test) instead of stable branches like develop. While this is appropriate for testing coordinated changes across repositories, ensure these feature branches are merged back to stable branches before this workflow change is merged to the main branch. Feature branch references in CI workflows can break when those branches are deleted after merge.

Copilot · 2026-01-15T08:53:32Z

          repository: rdkcentral/entservices-testframework
          path: entservices-testframework
-          ref: develop
+          ref: L2TestPlugin_COMRPC


Workflow is using feature branch references (L2TestPlugin_COMRPC and Test) instead of stable branches like develop. While this is appropriate for testing coordinated changes across repositories, ensure these feature branches are merged back to stable branches before this workflow change is merged to the main branch. Feature branch references in CI workflows can break when those branches are deleted after merge.

Copilot · 2026-01-15T08:53:32Z

          repository: rdkcentral/entservices-apis
          path: entservices-apis
-          ref: ${{env.INTERFACES_REF}}
+          ref: Test


Workflow is using feature branch references (L2TestPlugin_COMRPC and Test) instead of stable branches like develop. While this is appropriate for testing coordinated changes across repositories, ensure these feature branches are merged back to stable branches before this workflow change is merged to the main branch. Feature branch references in CI workflows can break when those branches are deleted after merge.

Suggested change

ref: Test

ref: develop

Copilot · 2026-01-15T08:53:32Z

          repository: rdkcentral/entservices-testframework
          path: entservices-testframework
-          ref: develop
+          ref: L2TestPlugin_COMRPC


Workflow is using feature branch references (L2TestPlugin_COMRPC and Test) instead of stable branches. This is a concern for the same reason as in L2-tests.yml - ensure these feature branches exist and are coordinated, or use stable branch references after the dependent changes are merged. Feature branch references can cause CI failures when branches are deleted.

Copilot · 2026-01-15T08:53:32Z

          repository: rdkcentral/entservices-peripherals
          path: entservices-peripherals
-          ref: develop
+          ref: L2TestPlugin_COMRPC


Workflow is using feature branch references (L2TestPlugin_COMRPC and Test) instead of stable branches. This is a concern for the same reason as in L2-tests.yml - ensure these feature branches exist and are coordinated, or use stable branch references after the dependent changes are merged. Feature branch references can cause CI failures when branches are deleted.

Copilot · 2026-01-15T08:53:33Z

          repository: rdkcentral/entservices-apis
          path: entservices-apis
-          ref: ${{env.INTERFACES_REF}}
+          ref: Test


Workflow is using feature branch references (L2TestPlugin_COMRPC and Test) instead of stable branches. This is a concern for the same reason as in L2-tests.yml - ensure these feature branches exist and are coordinated, or use stable branch references after the dependent changes are merged. Feature branch references can cause CI failures when branches are deleted.

Suggested change

ref: Test

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot · 2026-01-30T07:04:24Z

          repository: rdkcentral/entservices-testframework
          path: entservices-testframework
-          ref: develop
+          ref: L2TestPlugin_COMRPC


The workflow now references the branch 'L2TestPlugin_COMRPC' instead of 'develop'. This appears to be a temporary branch for testing COMRPC changes. Before merging, ensure that:

This branch exists and contains the necessary COMRPC changes

There is a plan to either merge this branch back to develop or update this reference to 'develop' once the COMRPC changes are integrated

The same branch reference update is coordinated across both entservices-peripherals and entservices-testframework repositories

Copilot · 2026-01-30T07:04:24Z

          repository: rdkcentral/entservices-peripherals
          path: entservices-peripherals
-          ref: develop
+          ref: L2TestPlugin_COMRPC


The workflow now references the branch 'L2TestPlugin_COMRPC' instead of 'develop'. This appears to be a temporary branch for testing COMRPC changes. Before merging, ensure that:

This branch exists and contains the necessary COMRPC changes

There is a plan to either merge this branch back to develop or update this reference to 'develop' once the COMRPC changes are integrated

The same branch reference update is coordinated across both entservices-peripherals and entservices-testframework repositories

Update L2-tests.yml

8c6545b

smanes0213 requested a review from a team as a code owner January 5, 2026 11:23

smanes0213 added 3 commits January 5, 2026 16:57

Update L2-tests.yml

fef0a9d

Increase Timeout for tests in Thunder

b2cece4

Increase Timeout for tests in Thunder

4f55488

smanes0213 changed the title ~~Update L2-tests.yml~~ Add support for COMRPC changes in L2Tests plugin in Testframework repo Jan 7, 2026

smanes0213 added 7 commits January 7, 2026 14:35

Change entservices-apis checkout ref to Test branch in L1 workflow

0c8c0dd

Fix deprecated-declarations warnings treated as errors

2064a80

Changed -Wno-deprecated-declarations to -Wno-error=deprecated-declarations to allow warnings from Thunder's VirtualInput.h without failing the build.

Suppress deprecated declarations warnings in workflows

e798f31

Stop and clear the WorkerPool before destruction

1d713cc

Update test_FrontPanel.cpp

cc7b365

Update test_FrontPanel.cpp

70f733b

Remove Debug flag while building thunder

6f1b8c6

smanes0213 requested a review from Copilot January 15, 2026 08:50

Copilot started reviewing on behalf of smanes0213 January 15, 2026 08:51 View session

Merge branch 'develop' into L2TestPlugin_COMRPC

dce3391

Copilot AI reviewed Jan 15, 2026

View reviewed changes

mkumar705 added 2 commits January 29, 2026 18:12

Added patch file for L2 test plugins

5656f3e

Update L2-tests.yml

8ea6683

Copilot AI review requested due to automatic review settings January 30, 2026 06:59

Copilot started reviewing on behalf of MukeshkumarK January 30, 2026 06:59 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Navigation Menu

Uh oh!

Add support for COMRPC changes in L2Tests plugin in Testframework repo - #129

Add support for COMRPC changes in L2Tests plugin in Testframework repo#129
smanes0213 wants to merge 14 commits into
developfrom
L2TestPlugin_COMRPC

smanes0213 commented Jan 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI Jan 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

smanes0213 commented Jan 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants