Feature/cert extn sdk #271
Conversation
|
Core SDK - MFOS standalone sanity report: |
There was a problem hiding this comment.
typo with onFireboltInterections (onFireboltInteractions)
| } | ||
| ], | ||
| "result": { | ||
| "name": "success", |
There was a problem hiding this comment.
no need for success fields in results
| } | ||
| ], | ||
| "result": { | ||
| "name": "success", |
There was a problem hiding this comment.
no need for success fields in result
| "name": "Screen capture and sends back the image stream with base64 encoded", | ||
| "params": [], | ||
| "result": { | ||
| "name": "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/wcAAgMBApDPF90AAAAASUVORK5CYII=", |
There was a problem hiding this comment.
Think we need to consider returning the image asynchronously as chunks
| "result": { | ||
| "name": "event", | ||
| "value": { | ||
| "interactionRequest": { |
There was a problem hiding this comment.
probably could just have this be a json string instead individual fields being in the schema here.
| "params": [ | ||
| { | ||
| "name": "uploadPath", | ||
| "value": "http://example.com/upload" |
There was a problem hiding this comment.
How would the upload actually work? Wouldn't this functionality require additional details, such as HTTP auth headers, etc?
| }, | ||
| { | ||
| "name": "healthCheck", | ||
| "summary": "", |
There was a problem hiding this comment.
This one needs a summary
| }, | ||
| { | ||
| "name": "appPerformance", | ||
| "summary": "", |
There was a problem hiding this comment.
Same as above; needs a summary
| "name": "appPerformanceResult", | ||
| "summary": "Result of the interaction", | ||
| "schema": { | ||
| "$ref": "#/components/schemas/AppPerformanceSnapshotResult" |
There was a problem hiding this comment.
Wondering if we should align healthCheck and appPerformance methods, as they seem to be related and return similar values.
Maybe systemHealthCheck and appHealthCheck?
| "type": "number", | ||
| "description": "The cpu usage of the system" | ||
| }, | ||
| "deviceMemory": { |
There was a problem hiding this comment.
What do you think about using other adjectives on these values? It's reasonable that we might want to expand this object to return more fields later on, so it might be helpful to be clear in our responses now e.g.
cpuLoad1minAverage
cpuLoad5minAverage
deviceMemoryUsed
memoryUsed
memoryLimit
We also might want to note the units in the field descriptions, particularly on the memory values. I assume they're in Mb?
…to feature/cert-extn-sdk
|
Core SDK - MFOS standalone sanity report: |
|
Core SDK - MFOS standalone sanity report: |
No description provided.