Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 0 additions & 149 deletions .github/workflows/cxx-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,6 @@ jobs:
name: core
path: src/sdks/core

- name: Upload Manage SDK
uses: actions/upload-artifact@v4
with:
name: manage
path: src/sdks/manage

- name: Upload Discovery SDK
uses: actions/upload-artifact@v4
with:
name: discovery
path: src/sdks/discovery

core_sdk:
name: Build Core SDK
needs: [thunder, openrpc]
Expand Down Expand Up @@ -175,143 +163,6 @@ jobs:
append: true
path: code-coverage-results.md


manage_sdk:
name: Build Manage SDK
needs: [thunder, openrpc]
runs-on: ubuntu-latest
container:
image: node:23.3.0
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Download Manage SDK
uses: actions/download-artifact@v4
with:
name: manage
path: /__w/firebolt-apis/firebolt-apis/src/sdks/manage

- name: Download Thunder
uses: actions/download-artifact@v4
with:
name: thunder
path: /__w/thunder/install/

- name: Cache npm dependencies
uses: actions/cache@v3
with:
path: ~/.npm
key: deps-node-modules-${{ hashFiles('package-lock.json') }}

- name: Install npm dependencies
run: |
apt update
apt install -y cmake
npm install

- name: Generate manage SDK source code
run: |
.github/workflows/utils.sh generate_cpp_manage_sdk_source_code

- name: Build CXX Manage SDK
run: |
apt install -y python3-pip python3.11-venv
python3 -m venv firebolt-env
source firebolt-env/bin/activate
pip install gcovr

.github/workflows/utils.sh build_manage_cpp_sdk

- name: Test and Generate coverage report
run: .github/workflows/utils.sh generate_manage_sdk_coverage_report

- name: Display coverage report
uses: irongut/[email protected]
with:
filename: coverage/coverage.cobertura.xml
badge: true
fail_below_min: false
format: markdown
hide_branch_rate: false
hide_complexity: true
indicators: true
output: both
thresholds: '50 20'

- name: Replace badge title in PR comment
run: sed -i 's/Code%20Coverage/Manage%20Coverage%20Report/g' code-coverage-results.md

- name: Add coverage PR comment
uses: marocchino/sticky-pull-request-comment@v2
with:
recreate: false
append: true
path: code-coverage-results.md

discovery_sdk:
name: Build Discovery SDK
needs: [thunder, openrpc]
runs-on: ubuntu-latest
container:
image: node:23.3.0
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Download Discovery SDK
uses: actions/download-artifact@v4
with:
name: discovery
path: /__w/firebolt-apis/firebolt-apis/src/sdks/discovery

- name: Download Thunder
uses: actions/download-artifact@v4
with:
name: thunder
path: /__w/thunder/install/

- name: Cache npm dependencies
uses: actions/cache@v3
with:
path: ~/.npm
key: deps-node-modules-${{ hashFiles('package-lock.json') }}

- name: Install npm dependencies
run: |
apt update
apt install -y cmake
npm install

- name: Generate discovery SDK source code
run: |
.github/workflows/utils.sh generate_cpp_discovery_sdk_source_code

- name: Build CXX Discovery SDK
run: |
apt install -y python3-pip python3.11-venv
python3 -m venv firebolt-env
source firebolt-env/bin/activate
pip install gcovr

.github/workflows/utils.sh build_discovery_cpp_sdk

- name: Test and Generate coverage report
run: .github/workflows/utils.sh generate_discovery_sdk_coverage_report

- name: Display coverage report
uses: irongut/[email protected]
with:
filename: coverage/coverage.cobertura.xml
badge: true
fail_below_min: false
format: markdown
hide_branch_rate: false
hide_complexity: true
indicators: true
output: both
thresholds: '50 20'

- name: Replace badge title in PR comment
run: sed -i 's/Code%20Coverage/Discovery%20Coverage%20Report/g' code-coverage-results.md

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
types:
- "completed"
workflows:
- "MFOS standalone sanity report - CORE,MANAGE,DISCOVERY"
- "MFOS standalone sanity report - CORE"

jobs:
comment-on-pr:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-standalone-mfos-tests.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: MFOS standalone sanity report - CORE,MANAGE,DISCOVERY
name: MFOS standalone sanity report - CORE

on:
repository_dispatch:
Expand Down Expand Up @@ -26,7 +26,7 @@ jobs:
fi

# Run tests
- name: Run Core Manage and Discovery tests and create assets
- name: Run Core tests and create assets
env:
EVENT_NAME: ${{ github.event_name }}
GITHUB_REF: ${{ github.ref }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/utils.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ async function createComment(github, context) {
const { issue_number, Passes, Failures, Pending, Skipped, ARTIFACT_URL, JOB_PATH } = process.env;

const body = `
MFOS standalone sanity report - CORE,MANAGE,DISCOVERY:
MFOS standalone sanity report - CORE:
Total Passes - ${Passes} Failures - ${Failures} Pending - ${Pending} Skipped - ${Skipped}
Report JSON/HTML Files: ${ARTIFACT_URL}
Job Logs: ${JOB_PATH}
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/utils.sh
Original file line number Diff line number Diff line change
Expand Up @@ -299,15 +299,10 @@ case "$1" in
getArtifactData) getArtifactData ;;
unzipArtifact) unzipArtifact ;;
generate_cpp_core_sdk_source_code) generate_cpp_sdk_source_code "core" ;;
generate_cpp_manage_sdk_source_code) generate_cpp_sdk_source_code "manage" ;;
generate_cpp_discovery_sdk_source_code) generate_cpp_sdk_source_code "discovery" ;;
cloneAndInstallThunder) cloneAndInstallThunder ;;
build_core_cpp_sdk) build_cpp_sdk "core" ;;
build_manage_cpp_sdk) build_cpp_sdk "manage" ;;
build_discovery_cpp_sdk) build_cpp_sdk "discovery" ;;
generate_core_sdk_coverage_report) generate_coverage_report "core" ;;
generate_manage_sdk_coverage_report) generate_coverage_report "manage" ;;
generate_discovery_sdk_coverage_report) generate_coverage_report "discovery" ;;
*)
echo "Invalid function specified."
exit 1
Expand Down
6 changes: 0 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@ dist/*
src/sdks/core/build/*
src/sdks/core/dist/*
src/sdks/core/test/transpiled-suite/*
src/sdks/discovery/build/*
src/sdks/discovery/dist/*
src/sdks/discovery/test/transpiled-suite/*
src/sdks/manage/build/*
src/sdks/manage/dist/*
src/sdks/manage/test/transpiled-suite/*
node_modules/*
test/transpiled-suite/*
.DS_Store
2 changes: 1 addition & 1 deletion .releaserc
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
[
"@semantic-release/git",
{
"assets": ["CHANGELOG.md", "package.json", "package-lock.json", "npm-shrinkwrap.json", "src/sdks/core/package.json", "src/sdks/manage/package.json", "src/sdks/discovery/package.json"]
"assets": ["CHANGELOG.md", "package.json", "package-lock.json", "npm-shrinkwrap.json", "src/sdks/core/package.json"]
}
],
[
Expand Down
16 changes: 4 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
"firebolt-version": "./src/js/version.mjs"
},
"workspaces": [
"src/sdks/core",
"src/sdks/manage",
"src/sdks/discovery"
"src/sdks/core"
],
"scripts": {
"fs:setup": "npm run clean && mkdir -p dist",
Expand Down
2 changes: 0 additions & 2 deletions src/cpp/src/Logger/Logger.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ class Logger
{
OpenRPC,
Core,
Manage,
Discovery,
PlayerProvider,
PlayerManager,
};
Expand Down
14 changes: 0 additions & 14 deletions src/js/github.io/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ packageJson.workspaces.forEach(async workspace => {
const specification = await readJson(path.join('dist', 'firebolt-specification.json'))
const openrpc = await readJson(path.join('dist', 'firebolt-open-rpc.json'))
const corerpc = await readJson(path.join('dist', 'firebolt-core-open-rpc.json'))
const managerpc = await readJson(path.join('dist', 'firebolt-manage-open-rpc.json'))
const discoveryrpc = await readJson(path.join('dist', 'firebolt-discovery-open-rpc.json'))

const capabilities = () => {
const getOrCreateCapMethodList = (capabilities, c) => capabilities[c] = capabilities[c] || { uses: [], manages: [], provides: [] }
Expand Down Expand Up @@ -178,18 +176,6 @@ if (version === 'latest') {
writeJson(path.join(parsedArgs.output, 'requirements', packageJson.version, 'specifications', 'firebolt-core-open-rpc.json'), corerpc)
}

// this is the firebolt Manage OpenRPC spec JSON
writeJson(path.join(parsedArgs.output, 'requirements', version, 'specifications', 'firebolt-manage-open-rpc.json'), managerpc)
if (version === 'latest') {
writeJson(path.join(parsedArgs.output, 'requirements', packageJson.version, 'specifications', 'firebolt-manage-open-rpc.json'), managerpc)
}

// this is the firebolt Discovery OpenRPC spec JSON
writeJson(path.join(parsedArgs.output, 'requirements', version, 'specifications', 'firebolt-discovery-open-rpc.json'), discoveryrpc)
if (version === 'latest') {
writeJson(path.join(parsedArgs.output, 'requirements', packageJson.version, 'specifications', 'firebolt-discovery-open-rpc.json'), discoveryrpc)
}

function channel(version) {
const parts = version.split("-")

Expand Down
6 changes: 0 additions & 6 deletions src/sdks/discovery/.npmignore

This file was deleted.

12 changes: 0 additions & 12 deletions src/sdks/discovery/CHANGELOG.md

This file was deleted.

1 change: 0 additions & 1 deletion src/sdks/discovery/CONTRIBUTING.md

This file was deleted.

1 change: 0 additions & 1 deletion src/sdks/discovery/LICENSE

This file was deleted.

1 change: 0 additions & 1 deletion src/sdks/discovery/NOTICE

This file was deleted.

26 changes: 0 additions & 26 deletions src/sdks/discovery/README.md

This file was deleted.

8 changes: 0 additions & 8 deletions src/sdks/discovery/jest.config.json

This file was deleted.

Loading
Loading