Skip to content

Conversation

vladimir-rangelov
Copy link
Contributor

@vladimir-rangelov vladimir-rangelov commented Sep 22, 2025

Both APIs are bidirectional compatible, but the API signatures are slightly different, which is an API breaking change, and this is the reason for their removal.

Here is the change -
unidirectional:

function entityInfo(data)
function purchasedContent(data)

bidirectional:
function entityInfo(entityId, assedId)
function purchasedContent(offeringType, programType)

@alkalinecoffee
Copy link
Contributor

alkalinecoffee commented Sep 23, 2025

Please provide a description in this PR as to why these are being removed (for historical purposes).

There are some schemas here that we can probably clean up now that the methods are gone:

- #/components/schemas/EntityInfoFederatedResponse
    - https://meta.comcast.com/firebolt/discovery#/definitions/EntityInfoResult
- #/components/schemas/EntityInfoFederatedRequest
    - #/components/schemas/EntityInfoParameters
- #/components/schemas/EntityInfoResult
- #/components/schemas/PurchasedContentFederatedRequest
    - #/components/schemas/FederatedRequest
- #/components/schemas/PurchasedContentParameters
- #/components/schemas/PurchasedContentFederatedResponse
    - #/components/schemas/FederatedRequest
    - #/components/schemas/PurchasedContentResult
- #/components/schemas/PurchasedContentResult

These could be removed but I'm hesitant to do so right now as they seem useful:

- https://meta.comcast.com/firebolt/entertainment/EntityInfo
- https://meta.comcast.com/firebolt/entertainment#/definitions/OfferingType

@vladimir-rangelov
Copy link
Contributor Author

Yes, I removed the unused schemas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants