fix: Screenshot link provided in report opens to 'Resource not found' #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neeradanelxsi
approved these changes
Mar 27, 2025
jbigel
approved these changes
Mar 28, 2025
ksentak
requested changes
Mar 28, 2025
| @@ -102,7 +102,11 @@ attachScreenshotLinks = () => { | |||
| if (urlPattern.test(preHTML)) { | |||
| // Replace plain text URLs with clickable hyperlinks | |||
| const updatedHTML = preHTML.replace(urlPattern, (url) => { | |||
| return '<a href="' + url + '" target="_blank" rel="noopener noreferrer">' + url + '</a>'; | |||
| let cleanedUrl = url; | |||
There was a problem hiding this comment.
I recommend a different approach. I suggest modifying the regex on line 61 to be:
const urlPattern = /(https:\/\/[^\s]+\.jpg)/g; This ensures that only URLs ending with .jpg are matched, making the pattern more precise and aligned with the expected use case. If there is text added before the ] but after the URL, the current split(']')[0] approach will not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.