RDKCOM-5547: RDKBNETWOR-84 DSLite feature integration with WanManager (Wg network…#120
Open
devinmungan wants to merge 1 commit into
Open
RDKCOM-5547: RDKBNETWOR-84 DSLite feature integration with WanManager (Wg network…#120devinmungan wants to merge 1 commit into
devinmungan wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
Sanity tests for ['RPI4 GW BB Kirkstone'] added. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Sanity tests for ['RPI4 GW BB Kirkstone'] added. |
sichevoi
reviewed
Jan 5, 2026
| fi | ||
|
|
||
| if ${@bb.utils.contains('DISTRO_FEATURES', 'dslite_v2', 'true', 'false', d)}; then | ||
| if ! grep -q '^<?define FEATURE_DSLITE_V2=True?>' ${S}/config/${XML_NAME}; then |
Krithiksha11
pushed a commit
to Krithiksha11/meta-rdk-wan
that referenced
this pull request
Jan 19, 2026
* RDKB-61232 : Upgrade Wan components to RC1.12.0a. (rdkcentral#106) Reason for change: Upgrade Wan components to RC1.12.0a. Test Procedure: Build should be passed. Priority: P1 Risks: Medium Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk> * Adding necessary DISTRO flags for T2 telemetry (rdkcentral#108) Signed-off-by: kavya.shivalingaiah@sky.uk <kavya.shivalingaiah@sky.uk> * Update CODEOWNERS * Deploy cla action * RDKB-62380 : Upgrade Wan components to v1.12.0 Upgrade Wan components to v1.12.0 Wan Manager SHARMAN-3449 : Global ipv6 pd address updated on erouter0 instead of brlan0 by @S-Parthiban-Selvaraj in rdkcentral#113 RDKCOM-5243 RDKBDEV-3075 remove dependency on dbus by @Sukanya673 in rdkcentral#99 TCXB7-6967 :Fix for LAN mac leak when the device is scanning DOCSIS by @S-Parthiban-Selvaraj in rdkcentral#118 RDKB-59877 : MAPT acceleration is not working ... by @S-Parthiban-Selvaraj in rdkcentral#120 RDKB-59957 : [XB-MAPT] MTU Sizes Differ Between Release and Sprint Build by @S-Parthiban-Selvaraj in rdkcentral#121 RDKB-59976 : IPv6 not Allocated to Wi-Fi Clients by @S-Parthiban-Selvaraj in rdkcentral#124 RDKBNETWOR-11: DhcpManager integration with WanManager (Wg network11 development) by @S-Parthiban-Selvaraj in rdkcentral#126 RDKB-57776: Develop ifacemanager_vlan for VlanManager. by @LakshminarayananShenbagaraj in rdkcentral#127 RDKB-60471 : Device.Time.TimeOffset returns junk value by @S-Parthiban-Selvaraj in rdkcentral#132 RDKB-60422 : {WANManager} Improvement - Handle Mutex properly on State Machine to avoid DML Stuck. by @LakshminarayananShenbagaraj in rdkcentral#133 SHARMAN-3454 : Wanmanager gets Crashed and Not able to reach internet on LAN and WAN due to webconfig post by @KavyaShivalingaiah in rdkcentral#139 RDKBACCL-907: [TDK][AUTO][BPI] CcspAdvSecuritySsp keeps restarting and eth_wan_mac value is not updated by @ksaipr036 in rdkcentral#138 Deploy cla action by @rdkcmf-jenkins in rdkcentral#128 RDKBDEV-3234: remove dependency on dbus by @pradeeptakdas in rdkcentral#129 RDKB-60124 : Add T2 for DNS by @sindhu-krishnan in rdkcentral#140 RDKB-58521 : WAN Manager Telemetry Markers 2.0 - Phase 1 by @KavyaShivalingaiah in rdkcentral#141 RDKB-61835 : Update Ipv6 sysevents when Ipv6 configured. #152 RDKB-61845: In telemetry2_0 Event markers are assigned without component name #153 PPP Manager Deploy cla action by @rdkcmf-jenkins in rdkcentral#33 DSL Manager Deploy cla action by @rdkcmf-jenkins in rdkcentral#18 IPOE Deploy cla action by @rdkcmf-jenkins in rdkcentral#10 BLDKCMF-64: GPLv2 Code in IPOEHealthCheck by @KavyaShivalingaiah in rdkcentral#12 RDKB-58521 : WAN Manager Telemetry Markers 2.0 - Phase 1 by @KavyaShivalingaiah in rdkcentral#11 GPON Manager Deploy cla action by @rdkcmf-jenkins in rdkcentral#17 RDKCOM-5404: RDKBDEV-3239 free JSON objects on failure to get reply by @pradeeptakdas in rdkcentral#19 RDKCOM-5403: RDKBDEV-3238 remove dependency on dbus by @pradeeptakdas in rdkcentral#18 Vlan Manager Deploy cla action by @rdkcmf-jenkins in rdkcentral#23 Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk> * Rebase Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk> * Rebase Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk> --------- Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk> Signed-off-by: kavya.shivalingaiah@sky.uk <kavya.shivalingaiah@sky.uk> Signed-off-by: Parthiban Selvaraj <parthiban.selvaraj@sky.uk> Co-authored-by: LakshminarayananShenbagaraj <166714137+LakshminarayananShenbagaraj@users.noreply.github.com> Co-authored-by: KavyaShivalingaiah <kavya.shivalingaiah@sky.uk> Co-authored-by: Stephen Barrett <sbarre01@users.noreply.github.com> Co-authored-by: rdkcmf <github@code.rdkcentral.com> Co-authored-by: Alan Ryan <20208488+Alan-Ryan@users.noreply.github.com>
…11 development) * RDKBNETWOR-86 : Move Device.DSLite. datamodel implementation to WAN Manager * add DISTRO feature "dslite_v2" and the feature flag FEATURE_DSLITE_V2 to the .xml file Signed-off-by: Devin Mungan <devin.mungan@infosys.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the WAN Manager BitBake recipe to wire in “next generation” DSLite support via a new DISTRO_FEATURES gate, enabling both a configure-time flag and a generated datamodel feature define.
Changes:
- Add an
EXTRA_OECONFconfigure option gated byDISTRO_FEATURES=dslite_v2. - Inject
<?define FEATURE_DSLITE_V2=True?>into the WAN Manager XML whendslite_v2is enabled.
Comments suppressed due to low confidence (1)
recipes-ccsp/ccsp/rdk-wanmanager.bb:94
- The grep guard may miss an existing define if the XML line is indented or otherwise not at column 1 (because the pattern is anchored with
^). In that case this block will insert a duplicateFEATURE_DSLITE_V2define, which can cause confusing build/datamodel behavior. Consider switching to a fixed-string match (e.g., grep -F) and/or allowing optional leading whitespace instead of anchoring to the start of the line.
if ${@bb.utils.contains('DISTRO_FEATURES', 'dslite_v2', 'true', 'false', d)}; then
if ! grep -q '^<?define FEATURE_DSLITE_V2=True?>' ${S}/config/${XML_NAME}; then
sed -i '2i <?define FEATURE_DSLITE_V2=True?>' ${S}/config/${XML_NAME}
fi
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Sanity tests for ['RPI4 GW BB Kirkstone'] added. |
S-Parthiban-Selvaraj
approved these changes
Mar 11, 2026
pradeeptakdas
changed the title
hpatel006c
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…11 development) (#126)
RDKBNETWOR-86 : Move Device.DSLite. datamodel implementation to WAN Manager
add DISTRO feature "dslite_v2" and the feature flag FEATURE_DSLITE_V2 to the .xml file