RDKB-64598 : Coverity issues in ccsp-moca component#33
Merged
GoutamD2905 merged 1 commit intodevelopfrom May 4, 2026
Merged
Conversation
Signed-off-by: SuneethaLakshmi <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses multiple Coverity findings in the ccsp-moca component by tightening pointer validation and preventing potential string/buffer overruns when interacting with MoCA HAL structures and parsing /proc/net/arp.
Changes:
- Add parameter NULL validation in
CosaDmlMocaIfReset()to prevent dereference warnings. - Ensure MoCA HAL fields are explicitly NUL-terminated before HAL calls (including
NodeTabooMask). - Fix potential ARP parsing buffer overruns in MRD by resizing buffers and tightening
fscanffield widths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/TR-181/board_sbapi/cosa_moca_webconfig_api.c | Adds explicit NodeTabooMask termination before updating HAL during rollback. |
| source/TR-181/board_sbapi/cosa_moca_apis.c | Adds NULL validation for MCfg and adds NodeTabooMask termination in multiple HAL interaction paths. |
| source/MRD/mrd.c | Prevents out-of-bounds writes by increasing ipAddr buffer and limiting MAC field width in ARP parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+573
to
+577
| /* Coverity CID 414230: STRING_NULL — validate all pointer params before any dereference */ | ||
| if ( !MCfg ) | ||
| { | ||
| CcspTraceWarning(("CosaDmlMocaIfReset -- MCfg is NULL\n")); | ||
| return ANSC_STATUS_FAILURE; |
GoutamD2905
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.