Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh #107 Update dsSetForceHDRMode expected status #108

Closed
wants to merge 1 commit into from
Closed

gh #107 Update dsSetForceHDRMode expected status #108

wants to merge 1 commit into from

Conversation

SrigayathryPugazhenthi
Copy link
Contributor

No description provided.

@SrigayathryPugazhenthi SrigayathryPugazhenthi changed the title Update dsSetForceHDRMode expected status #107 Update dsSetForceHDRMode expected status Mar 3, 2025
@SrigayathryPugazhenthi SrigayathryPugazhenthi changed the title #107 Update dsSetForceHDRMode expected status gh #107 Update dsSetForceHDRMode expected status Mar 3, 2025
AnandPandav
AnandPandav approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@AnandPandav AnandPandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

apatel859
apatel859 requested changes Mar 3, 2025
View reviewed changes
Copy link

@apatel859 apatel859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is change is not required. line 955 already says it will return error dsERR_OPERATION_NOT_SUPPORTED so no change required here. When I said document update I mean thunder API documentation in rdkservices

@SrigayathryPugazhenthi
Copy link
Contributor Author

Sure we can update the Thunder doc for the setForceHDR API saying platform will return NOT_SUPPORTED for unused hdr modes. Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apatel859 apatel859 apatel859 requested changes

@AnandPandav AnandPandav AnandPandav approved these changes

@lucienkennedylamb lucienkennedylamb lucienkennedylamb approved these changes

@hari22yuva hari22yuva Awaiting requested review from hari22yuva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SrigayathryPugazhenthi @AnandPandav @apatel859 @lucienkennedylamb