Skip to content

Conversation

@Nikita-Hakai
Copy link

Reason for change: To retrieve metrics data for supported ones as part of Easymesh's metrics collection
Test Procedure: Ensure client device is connected.
Risks: Medium
Priority: P1

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 74b69bf

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 74b69bf

Report detail: gist'

return 0;
}

static int get_channel_stats_handler(struct nl_msg *msg, void *arg)
Copy link

@mhughesacn mhughesacn Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nikita: Apologies for the delay. This was an awkward case to pin down.

Where did this routine come from? There is a code match.

I see a match to wavemon (GPLv3 licensed, Not OK) but wavemon credits iw:survey.c which has an ISC license (OK). There are other complications but I think it will be OK to use if an extra credit is inserted. Under line 28, add:

Also credit:
Copyright (c) 2007, 2008    Johannes Berg
Copyright (c) 2007        Andy Lutomirski
Copyright (c) 2007        Mike Kershaw
Copyright (c) 2008-2009        Luis R. Rodriguez
Licensed under the ISC license

Please append this same set of lines to NOTICE.
Please append a copy of the ISC license to the end of LICENSE (from https://spdx.org/licenses/ISC.html, from the license name to "...OF THIS SOFTWARE".)

Copy link
Author

@Nikita-Hakai Nikita-Hakai Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mhughesacn , sorry for the delayed updates. This totally skipped my noifications.

I have tried adding the specified license/notice as per your suggestion, however I still see copyright scan failure. Could you help me with what might be wrong here?

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: b4db6b4
Report detail: https://gist.github.com/rdkcmf-jenkins/4bf989bb7808b6058496804e3f87f2ac'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: b4db6b4

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: 15e68f0
Report detail: https://gist.github.com/rdkcmf-jenkins/f9c526aeb741b080ca17b3eb68026002'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 15e68f0

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: 1e7821c
Report detail: https://gist.github.com/rdkcmf-jenkins/5fc007721145546b8412fb0957030262'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 1e7821c

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: 1e7821c
Report detail: https://gist.github.com/rdkcmf-jenkins/28f934b268d5572f0dc6ca3216c49fc9'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 1e7821c

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: 33e2a59
Report detail: https://gist.github.com/rdkcmf-jenkins/63aec2722f7aa510ec68f855bcb97d17'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 33e2a59

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: 6e26d00
Report detail: https://gist.github.com/rdkcmf-jenkins/c501f1adfb85ce0317bbe983ec502fa8'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 6e26d00

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: d7084fd
Report detail: https://gist.github.com/rdkcmf-jenkins/a25570229ddc5cbf7efc73be72957af2'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: d7084fd

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: cd16df7
Report detail: https://gist.github.com/rdkcmf-jenkins/90faf84e026b86f6934adce4aa145035'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: cd16df7

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: 813c23c
Report detail: https://gist.github.com/rdkcmf-jenkins/712a744807390691fe16a9528764b619'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 813c23c

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: f6ec7df
Report detail: https://gist.github.com/rdkcmf-jenkins/fd054970e5d13804069521d7dd8b4eb3'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: f6ec7df

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: f6ec7df

Report detail: gist'

@mhughesacn
Copy link

Hi @Nikita-Hakai : I should probably have tagged you on my comment. Anyhow, nothing will get cleared until I handle it in the tools. But I need you to handle this as per standard, which isn't quite what you have now:

  • Please remove the ISC license from the source code and put it at the end of LICENSE instead. (Checksum change in recipes may need fixing.)
  • Please add the credit lines to the end of NOTICE ("Also credit"... to "Licensed under..."). NOTICE is at top level in the repo.
  • The credit lines also remain where you have them in platform_pi.c. Don't move them.

Thank you.

… commands

Reason for change: To retrieve metrics data for supported ones as part of Easymesh's metrics collection
Test Procedure: Ensure client device is connected.
Risks: Medium
Priority: P1

Signed-off-by: Nikita Hakai <[email protected]>
@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: 71eab19
Report detail: https://gist.github.com/rdkcmf-jenkins/67e0df36251589e5fc35ca0b1ec8761a'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 71eab19

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: fe28268
Report detail: https://gist.github.com/rdkcmf-jenkins/d045f45cf1db579581896142a85f54af'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: fe28268

Report detail: gist'

@Nikita-Hakai
Copy link
Author

hi @mhughesacn, please review this latest change. If this also not what is expected, could you please paste me the exact content so that I can accordingly modify and we can merge this.

@mhughesacn
Copy link

Hi @nikita:

I hope this is clear. If not, you can ping me on slack.

  1. In the top level LICENSE in this repository, append:
ISC License

Copyright <YEAR> <COPYRIGHT HOLDER>

Permission to use, copy, modify, and /or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies.

THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  1. In platform/raspberry-pi/platform_pi.c as of the current commit, delete the newly inserted lines 18-23. The full license doesn't live here.

  2. In top level (of this repo) NOTICE, append this to the end:

Copyright (c) 2007, 2008    Johannes Berg
Copyright (c) 2007        Andy Lutomirski
Copyright (c) 2007        Mike Kershaw
Copyright (c) 2008-2009        Luis R. Rodriguez
Licensed under the ISC license

Thank you.

Reason for change: append a copy of the ISC license
Risks: Low
Priority: P1
@rdkcmf-jenkins
Copy link
Contributor

b'## Copyright scan failure
Commit: 8b4e546
Report detail: https://gist.github.com/rdkcmf-jenkins/d88c38f190bf5b6039f4450773be0b64'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 8b4e546

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/rdk-wifi-hal/221/rdkb/components/opensource/ccsp/hal/rdk-wifi-hal

  • Commit: 8b4e546

Report detail: gist'

@rdkcmf-jenkins
Copy link
Contributor

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: Thanks Nikita

  • Commit: 8b4e546
    '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants