-
Notifications
You must be signed in to change notification settings - Fork 86
Retrieve available radio metrics and sta metrics using NL commands #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
|
| return 0; | ||
| } | ||
|
|
||
| static int get_channel_stats_handler(struct nl_msg *msg, void *arg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Nikita: Apologies for the delay. This was an awkward case to pin down.
Where did this routine come from? There is a code match.
I see a match to wavemon (GPLv3 licensed, Not OK) but wavemon credits iw:survey.c which has an ISC license (OK). There are other complications but I think it will be OK to use if an extra credit is inserted. Under line 28, add:
Also credit:
Copyright (c) 2007, 2008 Johannes Berg
Copyright (c) 2007 Andy Lutomirski
Copyright (c) 2007 Mike Kershaw
Copyright (c) 2008-2009 Luis R. Rodriguez
Licensed under the ISC license
Please append this same set of lines to NOTICE.
Please append a copy of the ISC license to the end of LICENSE (from https://spdx.org/licenses/ISC.html, from the license name to "...OF THIS SOFTWARE".)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mhughesacn , sorry for the delayed updates. This totally skipped my noifications.
I have tried adding the specified license/notice as per your suggestion, however I still see copyright scan failure. Could you help me with what might be wrong here?
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
Hi @Nikita-Hakai : I should probably have tagged you on my comment. Anyhow, nothing will get cleared until I handle it in the tools. But I need you to handle this as per standard, which isn't quite what you have now:
Thank you. |
… commands Reason for change: To retrieve metrics data for supported ones as part of Easymesh's metrics collection Test Procedure: Ensure client device is connected. Risks: Medium Priority: P1 Signed-off-by: Nikita Hakai <[email protected]>
f6ec7df to
71eab19
Compare
|
b'## Copyright scan failure |
71eab19 to
fe28268
Compare
|
b'## Copyright scan failure |
|
hi @mhughesacn, please review this latest change. If this also not what is expected, could you please paste me the exact content so that I can accordingly modify and we can merge this. |
|
Hi @nikita: I hope this is clear. If not, you can ping me on slack.
Thank you. |
Reason for change: append a copy of the ISC license Risks: Low Priority: P1
fe28268 to
8b4e546
Compare
|
b'## Copyright scan failure |
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
Reason for change: To retrieve metrics data for supported ones as part of Easymesh's metrics collection
Test Procedure: Ensure client device is connected.
Risks: Medium
Priority: P1