RDKB-61018:Calculate and forward device angle and distance using Wi-F… #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i CSI data.
Reason for change: Implemented logic to trigger a CSI Netlink (NL) command to pull
data when a CSI callback is registered and CSI is enabled for any client.
Test Procedure: 1) Load the OneWifi image onto the BPI platform.
2) Enable the CSI feature.
3) Connect a client device.
4) Start CSI data collection for the connected client and verify that
the data is received in the registered callback.
Priority: P1
Risks: Low
Signed-off-by: [email protected]
|
|
amarnathhullur
requested changes
Aug 11, 2025
| return RETURN_OK; | ||
| } | ||
|
|
||
| void *pick_link_elem_info(link_element_t *head, void *data, uint32_t data_len) |
Contributor
There was a problem hiding this comment.
What is the intent of this function as it is comparing the data with head->data and if both are same, it is returning the data back
Contributor
There was a problem hiding this comment.
Also I did not see the usage of this function.
|
|
||
| if (cur->data && (memcmp(cur->data, data, data_len) == 0)) { | ||
| free(cur->data); | ||
| *head = cur->next; |
Contributor
There was a problem hiding this comment.
free(cur) should also be done.
| } | ||
| } | ||
|
|
||
| return RETURN_ERR; |
Contributor
There was a problem hiding this comment.
should be return_OK right?
| __func__, __LINE__, radio_index); | ||
| for (uint32_t i = 0; i < ETH_ALEN; i++) { | ||
| wifi_hal_info_print("%x\n", mac[i]); | ||
| nla_put_u8(msg, i, mac[i]); |
Contributor
There was a problem hiding this comment.
Each Mac byte is to be added one by one is it?
| } else { | ||
| for (i = 0; i < len; i++) { | ||
| fprintf(fpg, " %02x", buf[i]); | ||
| if ((i != 0) && (i % 16 == 0)) { |
Contributor
There was a problem hiding this comment.
why do you need i != 0 check?
| { 2, 9, 0, 1, 1 }, | ||
| { 2, 9, 2, 100, 0 } | ||
| }; | ||
| uint8_t *p_str_mac = NULL; |
Contributor
There was a problem hiding this comment.
indentation from here onwards looks incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…i CSI data.
Reason for change: Implemented logic to trigger a CSI Netlink (NL) command to pull
data when a CSI callback is registered and CSI is enabled for any client.
Test Procedure: 1) Load the OneWifi image onto the BPI platform. 2) Enable the CSI feature.
3) Connect a client device.
4) Start CSI data collection for the connected client and verify that
the data is received in the registered callback.
Priority: P1
Risks: Low
Signed-off-by: [email protected]