-
Notifications
You must be signed in to change notification settings - Fork 86
DTMESH-646 [DT][OneWifi] DFS event updates #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTMESH-646 [DT][OneWifi] DFS event updates #395
Conversation
7e0aca4 to
58de720
Compare
c8a2747 to
f3bacd0
Compare
2f22350 to
6ca1a5c
Compare
| return 0; | ||
| } | ||
| } | ||
| if (dfs_nl_listen_start()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use indentation tool, there are problems across all code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed alignment using clang format
platform/qualcomm/platform_ext.c
Outdated
| int fd; | ||
|
|
||
| if (nl_fd != -1) { | ||
| wifi_hal_dbg_print("%s:%d: DFS socket registered already\n", __func__, __LINE__); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to error message
platform/qualcomm/platform_ext.c
Outdated
|
|
||
| fd = socket(PF_NETLINK, SOCK_RAW, NETLINK_ROUTE); | ||
| if (fd < 0) { | ||
| wifi_hal_dbg_print("%s:%d: failed to create socket: %d (%s)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to error message
platform/qualcomm/platform_ext.c
Outdated
| addr.nl_groups = RTMGRP_LINK; | ||
|
|
||
| if (bind(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) { | ||
| wifi_hal_dbg_print("%s:%d: failed to bind: %d (%s)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to error message
platform/qualcomm/platform_ext.c
Outdated
|
|
||
| static void *dfs_event_thread(void *arg) | ||
| { | ||
| char buf[32768] = {0}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be dynamic allocated only if we di have a event from driver?
platform/qualcomm/platform_ext.c
Outdated
| if (len > 0) { | ||
| parse_iwcustom_buffer(buf, len); | ||
| } else { | ||
| wifi_hal_dbg_print("%s:%d: recvfrom returned %d (%s)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to error message
platform/qualcomm/platform_ext.c
Outdated
| data += IW_EV_POINT_LEN - IW_EV_POINT_OFF; | ||
| switch (iwp->flags) { | ||
| case IEEE80211_EV_CAC_STARTED: | ||
| wifi_hal_dbg_print("DFS: CAC STARTED\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this events could be info message
34d96d7 to
eec67c7
Compare
35bef18 to
bdc9c6b
Compare
Reason for change: Update DFS events from driver to OneWifi Test Procedure: Radio State table updated with respective DFS event based on the state changes done on channel Priority: P1 Risks: Medium Signed-off-by: Magesh Renganathan <[email protected]>
bdc9c6b to
4d4e899
Compare
Reason for change: Update DFS events from driver to OneWifi
Test Procedure: Radio State table updated with respective DFS event based on the state changes done on channel
Priority: P1
Risks: Medium