Skip to content

Conversation

@MageshRenganathan
Copy link
Contributor

Reason for change: Update DFS events from driver to OneWifi

Test Procedure: Radio State table updated with respective DFS event based on the state changes done on channel

Priority: P1

Risks: Medium

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2025

CLA assistant check
All committers have signed the CLA.

@MageshRenganathan MageshRenganathan force-pushed the dfs_platform_changes branch 2 times, most recently from c8a2747 to f3bacd0 Compare October 22, 2025 04:58
@MageshRenganathan MageshRenganathan force-pushed the dfs_platform_changes branch 4 times, most recently from 2f22350 to 6ca1a5c Compare October 28, 2025 07:05
return 0;
}
}
if (dfs_nl_listen_start()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use indentation tool, there are problems across all code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed alignment using clang format

int fd;

if (nl_fd != -1) {
wifi_hal_dbg_print("%s:%d: DFS socket registered already\n", __func__, __LINE__);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to error message


fd = socket(PF_NETLINK, SOCK_RAW, NETLINK_ROUTE);
if (fd < 0) {
wifi_hal_dbg_print("%s:%d: failed to create socket: %d (%s)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to error message

addr.nl_groups = RTMGRP_LINK;

if (bind(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
wifi_hal_dbg_print("%s:%d: failed to bind: %d (%s)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to error message


static void *dfs_event_thread(void *arg)
{
char buf[32768] = {0};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be dynamic allocated only if we di have a event from driver?

if (len > 0) {
parse_iwcustom_buffer(buf, len);
} else {
wifi_hal_dbg_print("%s:%d: recvfrom returned %d (%s)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to error message

data += IW_EV_POINT_LEN - IW_EV_POINT_OFF;
switch (iwp->flags) {
case IEEE80211_EV_CAC_STARTED:
wifi_hal_dbg_print("DFS: CAC STARTED\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this events could be info message

@MageshRenganathan MageshRenganathan force-pushed the dfs_platform_changes branch 4 times, most recently from 34d96d7 to eec67c7 Compare October 31, 2025 08:30
gsathish86
gsathish86 previously approved these changes Oct 31, 2025
Reason for change: Update DFS events from driver to OneWifi

Test Procedure: Radio State table updated with respective DFS
event based on the state changes done on channel

Priority: P1

Risks: Medium

Signed-off-by: Magesh Renganathan <[email protected]>
@gsathish86 gsathish86 merged commit 36f2df9 into rdkcentral:develop Nov 7, 2025
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
@MageshRenganathan MageshRenganathan deleted the dfs_platform_changes branch November 11, 2025 05:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants