-
Notifications
You must be signed in to change notification settings - Fork 0
RDKEMW-8844: Analyse and Improve L1 coverage #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
trupthi1403
commented
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors code organization by moving inline class and struct definitions from .cpp files to header files, improves thread safety in console mode operations, and adds conditional key mappings for unit tests.
- Moved
TimeoutQueue,TimeoutInfo,TimeoutInfoComparator, andrtHttpRequestExclass/struct definitions from implementation to header files for better code organization - Enhanced thread safety in console mode by using managed threads and shutdown flags to prevent race conditions and ensure proper cleanup
- Added conditional compilation support for additional Wayland key mappings when building for unit tests
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/jsc/JavaScriptUtils.cpp | Moved inline class/struct definitions to header; methods now reference classes from header |
| include/jsc/JavaScriptUtils.h | Added declarations for TimeoutQueue, TimeoutInfo, TimeoutInfoComparator, and rtHttpRequestEx |
| src/NativeJSRenderer.cpp | Replaced detached thread with managed thread; added shutdown flag and proper thread cleanup |
| include/NativeJSRenderer.h | Added thread member, shutdown flag, and static consoleLoop variable |
| src/linux/KeyInput.cpp | Added conditional key mappings for unit test builds |
| include/jsc/JavaScriptContext.h | Made setPlaybackStartTime virtual |
| include/EssosInstance.h | Whitespace/formatting changes |
| .github/workflows/jsruntime_L1tests.yml | Updated test reference branch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/NativeJSRenderer.cpp
Outdated
| bool NativeJSRenderer::consoleLoop = true; | ||
| void handleDevConsoleSigInt(int /*sig*/) { | ||
| NativeJSRenderer::consoleLoop = false; | ||
| } |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The static consoleLoop variable is accessed from multiple threads (signal handler and main thread) without synchronization. Consider using std::atomic<bool> instead of bool for thread-safe access.
73d275b to
750f0a1
Compare
Reason for change: Changes done to compile newly added test cases
Test Procedure: Able to build and run test cases in CI
Risks: low
Priority: P2
750f0a1 to
ea530cb
Compare