Skip to content

RDKE-778 : Replace script with rdm binary - rdkfwupgrader #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025

Conversation

Saranya2421
Copy link
Contributor

No description provided.

@Saranya2421 Saranya2421 requested review from a team as code owners April 10, 2025 12:52
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ AravindanNC
✅ Saranya2421
❌ Saranya


Saranya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

v_secure_system("sh /etc/rdm/rdmBundleMgr.sh '%s' '%s' >> /opt/logs/rdm_status.log 2>&1", response->dlCertBundle, response->cloudFWLocation);
SWLOG_INFO("/etc/rdm/rdmBundleMgr.sh started and completed\n");
SWLOG_INFO("Calling rdm Versioned_app download to process bundle update\n");
v_secure_system("rdm -v \"%s\" >> /opt/logs/rdm_status.log 2>&1", response->dlCertBundle);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a condition if rdm binary file is present then call rdm insted calling directly.
I could not see removal of "rdmBundleMgr.sh" script from rootfs? Whether our plan is to keep this script as well in the rootfs? If yes then we can have one more condition like if rdmBundleMgr.sh script is present then call this script. This should be fallback to rdm binary.

What is the use of -v option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rdmBundleMgr.sh script is removed already from the rootfs. Option -v denotes the versioned app which is introduced newly for downloading Bundle Apps. [ These Changes were done as part of US RDK-56082].

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to check whether rdm binary exists.
rdkvfwupdater2.txt

`250411-14:23:42.332751 [mod=FWUPG, lvl=INFO] [tid=16788] peripheralFirmwares:

250411-14:23:42.332784 [mod=FWUPG, lvl=INFO] [tid=16788] dlCertBundle: ca-store-update-bundle:0.5

250411-14:23:42.332817 [mod=FWUPG, lvl=INFO] [tid=16788] cloudPDRIVersion:

250411-14:23:42.332849 [mod=FWUPG, lvl=INFO] [tid=16788] rdmCatalogueVersion:

250411-14:23:42.333052 [mod=FWUPG, lvl=INFO] [tid=16788] Calling rdm Versioned_app download to process bundle update

250411-14:23:42.333134 [mod=FWUPG, lvl=INFO] [tid=16788] RDM binary is present

250411-14:23:44.847525 [mod=FWUPG, lvl=INFO] [tid=16788] RDM Versioned app Download started and completed

250411-14:23:44.847651 [mod=FWUPG, lvl=INFO] [tid=16788] Optimize lastDnldFile: ELTE11MWR_MIDDLEWARE_DEV_develop_20250410135939.bin

250411-14:23:44.847706 [mod=FWUPG, lvl=INFO] [tid=16788] last_dwnl_status=1

250411-14:23:44.847802 [mod=FWUPG, lvl=INFO] [tid=16788] current_img_status=0
`

Copy link
Contributor

@satya200 satya200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@Saranya2421 Saranya2421 merged commit 65d27a4 into develop Apr 15, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants