-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDKTV-35484 Add deviceIdentification plugin details into deviceinfo #6142
Open
ramkumarpraba
wants to merge
15
commits into
rdkcentral:sprint/25Q1
Choose a base branch
from
ramkumarpraba:sprint/25Q1_RDKTV-35484_V1
base: sprint/25Q1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RDKTV-35484 Add deviceIdentification plugin details into deviceinfo #6142
ramkumarpraba
wants to merge
15
commits into
rdkcentral:sprint/25Q1
from
ramkumarpraba:sprint/25Q1_RDKTV-35484_V1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
RDKTV-35484 Add deviceIdentification plugin details into deviceinfo - sprint/25Q1 synup
RDKTV-34462: Extending hibernate delay to 30 sec
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
sprint/25Q1 synup
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
mhughesacn
reviewed
Mar 14, 2025
@@ -0,0 +1,119 @@ | |||
diff --git a/interfaces/Ids.h b/interfaces/Ids.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a header giving the source of the patch i.e. any new or changed code here.
Please explain why the patch is changing a copyright from RDK Management to Metrological? The copyright gives the owner of the code; it would be unusual for this to change.
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
Reason for change: Add chipset property to DeviceInfo Plugin Test Procedure: verify build success and basic test Risks: Low Priority: P1 Signed-off-by: [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Add chipset property to DeviceInfo Plugin
Test Procedure: verify build success and basic test
Risks: Low
Priority: P1
Signed-off-by: [email protected]