RDK-56804: Implement Authentication Callback #6169
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o call webkit_authenticate with a pk12 certificate instead of a nullptr placeholder. Reverts back to previous functionality if Glib version is less than 2.72 or if a certificate cannot be obtained.
…o call webkit_authenticate with a pk12 certificate instead of a nullptr placeholder. Reverts back to previous functionality if Glib version is less than 2.72 or if a certificate cannot be obtained.
emutavchi
requested changes
Mar 26, 2025
| out: | ||
| if (error) | ||
| { | ||
| TRACE(Trace::Information ("AUTHENTICATION:Cert load failed. %s", error ? error->message : "unknown")); |
There was a problem hiding this comment.
this code path should be taken if cert is null too.
| else | ||
| { | ||
| TRACE(Trace::Information ("AUTHENTICATION:Sending cert to webkit")); | ||
| webkit_authentication_request_authenticate(request, webkit_credential_new_for_certificate(cert, WEBKIT_CREDENTIAL_PERSISTENCE_NONE)); |
There was a problem hiding this comment.
I believe cert and credential need to be unrefed after providing to webkit_authentication_request_authenticate().
…r is sent in the event that no cert object is produced and fixed trace logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented authenticationCallback in WebKitImplementation in order to call webkit_authenticate with a pk12 certificate instead of a nullptr placeholder. Reverts back to previous functionality if Glib version is less than 2.72 or if a certificate cannot be obtained.
Reason for Change: Required as Webkit 2.38+ and libsoup3 don't automatically fall back to user certs provided by TLS envs
Risks: Medium
Priority: P1