Skip to content

DELIA-69147:In several places in RDKservices uninitialized variables are used #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sprint/25Q4
Choose a base branch
from
+12 −8
Open

DELIA-69147:In several places in RDKservices uninitialized variables are used #6427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a61eb
DELIA-69147:In several places in RDKservices uninitialized variables …
agampa263 Oct 31, 2025
1bc1441
Merge branch 'sprint/25Q4' into sprint/25Q4
anand-ky Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions StateObserver/StateObserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,12 @@ namespace WPEFramework {
checkForStandalone = false;
}
IARM_Bus_SYSMgr_GetSystemStates_Param_t param;
IARM_Bus_Call(IARM_BUS_SYSMGR_NAME, IARM_BUS_SYSMGR_API_GetSystemStates, &param, sizeof(param));
IARM_Result_t res = IARM_Bus_Call(IARM_BUS_SYSMGR_NAME, IARM_BUS_SYSMGR_API_GetSystemStates, &param, sizeof(param));
JsonArray response_arr;
for( std::vector<string>::iterator it = pname.begin(); it!= pname.end(); ++it )
if(res == IARM_RESULT_SUCCESS)
{
for( std::vector<string>::iterator it = pname.begin(); it!= pname.end(); ++it )
{
string err_str="none";
JsonObject devProp;
if(*it == SYSTEM_CHANNEL_MAP)
Expand Down Expand Up @@ -589,6 +591,7 @@ namespace WPEFramework {
}

}
}

response["properties"]=response_arr;
Copy link
Contributor

@srikanth-vv srikanth-vv Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of error, what would be the output of the json request. Make sure the response still comes as valid error message.

Copy link
Contributor

@npoltorapavlo npoltorapavlo Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be empty array, @srikanth-vv . #6421 (comment)

#if(DEBUG_INFO)
Expand Down
13 changes: 7 additions & 6 deletions SystemServices/SystemServices.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,16 +1815,17 @@ namespace WPEFramework {
LOGINFO("Got cached NetworkStandbyMode: '%s'", m_networkStandbyMode ? "true" : "false");
}
else {
IARM_Bus_PWRMgr_NetworkStandbyMode_Param_t param;
IARM_Bus_PWRMgr_NetworkStandbyMode_Param_t param = {};
IARM_Result_t res = IARM_Bus_Call(IARM_BUS_PWRMGR_NAME,
IARM_BUS_PWRMGR_API_GetNetworkStandbyMode, (void *)&param,
sizeof(param));
bool nwStandby = param.bStandbyMode;

LOGWARN("getNetworkStandbyMode called, current NwStandbyMode is: %s\n",
nwStandby?("Enabled"):("Disabled"));
response["nwStandby"] = nwStandby;

if (IARM_RESULT_SUCCESS == res) {
bool nwStandby = param.bStandbyMode;

LOGWARN("getNetworkStandbyMode called, current NwStandbyMode is: %s\n",
nwStandby?("Enabled"):("Disabled"));
response["nwStandby"] = nwStandby;
retVal = true;
m_networkStandbyMode = nwStandby;
m_networkStandbyModeValid = true;
Expand Down
Loading