RDKVREFPLT-4610:Logs are not getting uploaded to the log server #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Modified uploadSTBLogs script to handle MTLS case for community Test Procedure: Build should pass Risks: Low Signed-off-by: Lakshmipriya [email protected]
shibu-kv
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Adding a whole lot of custom logic based on COMMUNITY_BUILDS doesn't seem right .
Will have to check what was there in the function sendTLSSSRRequest
And make it generic in the sense like without TLS or making it explicit that its insecure.
In this era enabling or recommending an insecure connection doesn't look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Modified uploadSTBLogs script to handle MTLS case for community
Test Procedure: Build should pass
Risks: Low
Signed-off-by: Lakshmipriya [email protected]