Reason for change: telemetry Turn key changes for RDK-E #34
Conversation
Test Procedure: Refer JIRA Risks: Medium Priority: P1 Signed-off-by: nanimatta <[email protected]>
nanimatta
force-pushed
the
topic/RDKEMW-1144
branch
from
6ab4e26 to
ca7e796
Compare
Coverity Issue - Data race conditionAccessing "isXconfInit" without holding lock "xcThreadMutex". Elsewhere, "isXconfInit" is written to with "xcThreadMutex" held 1 out of 2 times (1 of these accesses strongly imply that it is necessary). Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Check of thread-shared field evades lock acquisitionThread1 sets "isXconfInit" to a new value. Now the two threads have an inconsistent view of "isXconfInit" and updates to fields correlated with "isXconfInit" may be lost. High Impact, CWE-543 How to fixGuard the modification of "isXconfInit" and the read used to decide whether to modify "isXconfInit" with the same set of locks. Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
…o topic/RDKEMW-1144
…o topic/RDKEMW-1144
nanimatta
force-pushed
the
topic/RDKEMW-1144
branch
from
b380dbd to
ba08fa2
Compare
source/dcautil/dca.c
Outdated
| @@ -26,6 +26,7 @@ | |||
| #include <ctype.h> | |||
| #include <pthread.h> | |||
|
|
|||
| #include <pthread.h> | |||
There was a problem hiding this comment.
Duplicate includes. Already present in previous line
Test Procedure: Refer JIRA
Risks: Medium
Priority: P1