1.4.0 release changelog updates #39
Conversation
Reason for change: leverage certificates provisioned on a device. Test Procedure: Telemetry report should upload successfully Risks: None Priority: P1 Change-Id: I2a73a9c0aa40262817016987450d12bda9ee7efc Signed-off-by: Ankur Adroja <[email protected]> (cherry picked from commit 55c0e1d5eb96980fd9c9d477329e9e476df46b3c)
Reason for change: Added require info logs Test Procedure: Build and test Risks: None Priority: P1 Change-Id: I99b7f95dc6b22377d5407af1ab275358c79372f6 Signed-off-by: Ankur Adroja <[email protected]> (cherry picked from commit e3610ab5cce138e7e4eeca2c8c9f8850e86e9171) (cherry picked from commit 37d850d3c1cdd64f52352be6b1a2da40d34bac68)
Reason for change: Correct the Tr 181 data model. STBi p is being used in xconf request as CM Mac, changed it to Wan mac. STB Ip is taking time to get the data and it is not properly mapped Test Procedure: T2 request should be success, proper data need to be sent Risks: Low Signed-off-by: [email protected]
Reason for change: Include IUI version as mandatory field for video
platforms
Test Procedure: Ensure all messgaes for legacy XCONF based profile
includes field for IUI version
Risks: Low
Change-Id: Idffd01d5679aae4df7b602bea116decb5607ac38
RDK-53334: Integrate RDK cert selector API to telemetry.
RDK-55945 : sync codebase with stable2
RDK-56446: Rebase Latest develop changes
* RDKEMW-2400 : Workflow changes for nativebuild test Reason for change: observing errors L2 workflow ref https://github.com/rdkcentral/telemetry/actions/runs/13781897026/job/38541480615?pr=35 Test Procedure: No Regressions in L2 workflow Risks: Low Signed-off-by: [email protected] * Update native_full_build.yml
RDK-56229: Add IUI version as mandatory field
|
Kakkoth Vayalambron, Shibu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Code Coverage Summary |
| } | ||
|
|
||
| /* Add to List */ | ||
| insertNode(tmpHndl, tail); |
There was a problem hiding this comment.
Coverity Issue - Dereference after null check
Passing null pointer "tmpHndl" to "insertNode", which dereferences it.
Medium Impact, CWE-476
FORWARD_NULL
| if(count++ > 30){ | ||
| break; | ||
| } | ||
| sleep(1); |
There was a problem hiding this comment.
Coverity Issue - Waiting while holding a lock
Call to "sleep" might sleep while holding lock "scMutex".
Medium Impact, CWE-667
SLEEP
| pthread_join(dcmThread, NULL); | ||
| if(isXconfInit){ | ||
| pthread_mutex_lock(&xcThreadMutex); | ||
| isXconfInit = false; |
There was a problem hiding this comment.
Coverity Issue - Check of thread-shared field evades lock acquisition
Thread1 sets "isXconfInit" to a new value. Now the two threads have an inconsistent view of "isXconfInit" and updates to fields correlated with "isXconfInit" may be lost.
High Impact, CWE-543
LOCK_EVASION
How to fix
Guard the modification of "isXconfInit" and the read used to decide whether to modify "isXconfInit" with the same set of locks.
| pthread_cond_destroy(&xcThreadCond); | ||
| bexitDCMThread = false; | ||
| pthread_join(dcmThread, NULL); | ||
| if(isXconfInit){ |
There was a problem hiding this comment.
Coverity Issue - Data race condition
Accessing "isXconfInit" without holding lock "xcThreadMutex". Elsewhere, "isXconfInit" is written to with "xcThreadMutex" held 1 out of 2 times (1 of these accesses strongly imply that it is necessary).
Medium Impact, CWE-366
MISSING_LOCK
| strvalue[strlen(strvalue)-1] = '\0'; | ||
| } | ||
| ret = report_or_cache_data(strvalue, marker); | ||
| if(strvalue != NULL){ |
There was a problem hiding this comment.
Coverity Issue - Dereference before null check
Null-checking "strvalue" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
Medium Impact, CWE-476
REVERSE_INULL
| if(mutex_return != 0){ | ||
| T2Error("tProfile Mutex locking failed : %d \n",mutex_return); | ||
| if(mutex_return == EBUSY) | ||
| T2Error("tProfile Mutex is Busy, already the report generation might be in progress \n"); | ||
| return T2ERROR_FAILURE; |
There was a problem hiding this comment.
Coverity Issue - Missing unlock
Returning without unlocking "scMutex".
Medium Impact, CWE-667
LOCK
No description provided.