RDKCOM-5489: RDKBDEV-3338 Review and fix TR69 interface selection for bridge mode.#9
RDKCOM-5489: RDKBDEV-3338 Review and fix TR69 interface selection for bridge mode.#9aprasad-97 wants to merge 1 commit into
Conversation
pradeeptakdas
changed the title
|
All contributors have signed the CLA ✍️ ✅ |
| return MODE_ERROR; | ||
| } | ||
| CcspTr069PaTraceInfo(("%s: bridge_mode from sysevent = '%s'\n", __func__, buf)); | ||
| if (strcmp(buf, "2") != 0) |
There was a problem hiding this comment.
For router mode it will be zero. this condition will return mode as router for all values other than 2 which may not be proper. please confirm the values
There was a problem hiding this comment.
When we checked, the bridge_mode sysevent has a value of 0 in router mode. In bridge mode (both FB and PB modes), it has a value of 2. We haven’t seen any case where this sysevent takes any other value. That is why we added the condition check in this way.
If the suggestion is to explicitly specify and compare against the value 0 for router mode here, we can make that change as well.
There was a problem hiding this comment.
FB and PB will have different values. Please make the check explicit
|
Hi @aprasad-97 |
Reason for change: In pseudo bridge mode, the selected interface for TR069 currently is wan0 instead of “erouter0” and this need to be fixed. Risks: Low Signed-off-by: Aiswarya Prasad <aprasad@maxlinear.com>
pradeeptakdas
force-pushed
the
RDKBDEV-3338
branch
from
81e5f7c to
4e9e03e
Compare
|
Hi @aprasad-97 Please let us know if there is any update? |
4 participants
Reason for change: In pseudo bridge mode, the selected interface for TR069 currently is wan0 instead of “erouter0” and this need to be fixed.
Risks: Low
Signed-off-by: Aiswarya Prasad aprasad@maxlinear.com