Fix the stability issues in controller and agent #221

AswiniViswanathan · 2025-03-15T01:27:13Z

Fixed the following issues
1)CTRL DB BSSID table incorrect values [duplicate entries]
2)Freq band incorrect
3)Update to CTRL DB not woking for SSID and BSSID configs
4)freq band not updated to DB
5)Autoconfig renew based al mac is empty and added to check for al mac
7)Set channel fail in controller em even when agent is configured
8)Autoconfig renew fail when happens for both the radio

amarnathhullur

Lets have a discussion on these changes as some changes need more clarification.

amarnathhullur · 2025-03-17T19:14:05Z

src/agent/em_agent.cpp

@@ -287,9 +287,7 @@ void em_agent_t::handle_autoconfig_renew(em_bus_event_t *evt)
    em_cmd_t *pcmd[EM_MAX_CMD] = {NULL};
    unsigned int num;

-    if (m_orch->is_cmd_type_in_progress(evt->type) == true) {


Why is this check removed? Is the check not required?

It does not allow autoconfig renew simultaneously for both 2.4 and 5G

Reverted since its not required

amarnathhullur · 2025-03-17T22:50:25Z

src/dm/dm_bss_list.cpp

@@ -121,7 +121,7 @@ dm_orch_type_t dm_bss_list_t::get_dm_orch_type(db_client_t& db_client, const dm_
    pbss = get_bss(key);

    if (pbss != NULL) {
-        if (entry_exists_in_table(db_client, bss_mac_str) == false) {
+        if (entry_exists_in_table(db_client, key) == false) {


This is a significant change to have the key be different, Has this change been properly tested?

Yes amarnath. I did test it and it works fine. Issue is while adding an entry key is construction as combination of bss mac haultype but this check uses only mac.

amarnathhullur · 2025-03-17T23:04:20Z

src/dm/dm_radio_list.cpp

@@ -196,7 +196,7 @@ int dm_radio_list_t::update_db(db_client_t& db_client, dm_orch_type_t op, void *
    switch (op) {
 		case dm_orch_type_db_insert:
 			ret = insert_row(db_client, key, radio_mac_str, info->enabled,
-						info->media_data.media_type, info->media_data.band, info->media_data.center_freq_index_1, info->media_data.center_freq_index_1,


What is the band in media_data which was earlier used?

media_data is a new variable introduced recently, not exactly sure on the exact purpose. Band is the variable which is updated in webconfig translator and also on the agent side implementation.

Should the webconfig translator and the agent needs to change to update media_data.band instead of using info.band?

I will discuss with soumya and get the information on media_data struct and update it the right way, but for M2 we have to updated the band variable.

amarnathhullur · 2025-03-17T23:05:22Z

src/dm/dm_radio_list.cpp

@@ -261,6 +261,7 @@ int dm_radio_list_t::sync_db(db_client_t& db_client, void *ctx)
        info.enabled = db_client.get_number(ctx, 3);
        info.media_data.media_type = db_client.get_number(ctx, 4);
        info.media_data.band = db_client.get_number(ctx, 5);
+	info.band = (em_freq_band_t) db_client.get_number(ctx, 5);


What is the need for this change?

media_data is not updated because of which frequency band is also not updated. Modified to use band variable which is updated from M1.

amarnathhullur · 2025-03-17T23:06:39Z

src/em/channel/em_channel.cpp

@@ -1950,7 +1952,9 @@ void em_channel_t::process_msg(unsigned char *data, unsigned int len)
            break;

        case em_msg_type_channel_sel_rsp:
-            handle_channel_sel_rsp(data, len);
+		if (get_service_type() == em_service_type_ctrl) {


Is the understanding that this needs to be processed only in controller?

Yes thats correct

amarnathhullur · 2025-03-17T23:16:07Z

src/em/config/em_configuration.cpp

+		if (memcmp(radio->get_radio_interface_mac(), get_radio_interface_mac(), sizeof(mac_address_t)) != 0) {
+			continue;
+		}
+	   found++;


indentation incorrect

amarnathhullur · 2025-03-17T23:18:52Z

src/orch/em_orch_ctrl.cpp

+             }
+	    else if (em->get_state() == em_state_ctrl_configured) {
+                 return true;
+	    }


you can add an || instead of if, elseif as you are returning same value

amarnathhullur · 2025-03-17T23:18:59Z

src/orch/em_orch_ctrl.cpp

+                return true;
+            } else if( em->get_state() == em_state_ctrl_channel_selected) {
+		return true;
+	    }


you can add an || instead of if, elseif as you are returning same value

amarnathhullur · 2025-03-17T23:20:01Z

src/orch/em_orch_ctrl.cpp

-                        queue_push(pcmd->m_em_candidates, em);
-                        count++;
-                    }
+		if (em->is_al_interface_em() == false) {


The for loop is removed, significant change.

SSID change is for all EM except the AL EM.

Ok, how will this be applied for all EM? Is this function called for all EM?

Yes, it is.

amarnathhullur · 2025-03-17T23:20:16Z

src/orch/em_orch_ctrl.cpp

-                    }
+		if (em->is_al_interface_em() == false) {
+			dm_easy_mesh_t::macbytes_to_string(em->get_radio_interface_mac(), mac_str);
+			printf("%s:%d Set SSSID : %s push to queue \n", __func__, __LINE__,mac_str);


typo in SSID

amarnathhullur · 2025-03-18T19:43:50Z

src/dm/dm_radio_list.cpp

@@ -196,7 +196,7 @@ int dm_radio_list_t::update_db(db_client_t& db_client, dm_orch_type_t op, void *
    switch (op) {
 		case dm_orch_type_db_insert:
 			ret = insert_row(db_client, key, radio_mac_str, info->enabled,
-						info->media_data.media_type, info->media_data.band, info->media_data.center_freq_index_1, info->media_data.center_freq_index_1,


Should the webconfig translator and the agent needs to change to update media_data.band instead of using info.band?

amarnathhullur · 2025-03-18T19:48:16Z

src/orch/em_orch_ctrl.cpp

-                        queue_push(pcmd->m_em_candidates, em);
-                        count++;
-                    }
+		if (em->is_al_interface_em() == false) {


Ok, how will this be applied for all EM? Is this function called for all EM?

amarnathhullur · 2025-03-18T19:49:30Z

src/orch/em_orch_ctrl.cpp

@@ -455,6 +468,14 @@ unsigned int em_orch_ctrl_t::build_candidates(em_cmd_t *pcmd)
                break;

            case em_cmd_type_set_channel:
+                dm = pcmd->get_data_model();


How was set_channel working earlier without the below change?

Testing performed: 1)On board remote and local agent 2)Verified not duplicate entries in DB 3)Autoconfig renew success when controller /agent is restarting

amarnathhullur · 2025-03-20T09:19:43Z

src/em/config/em_configuration.cpp

+	for (i = 0; i < dm->m_num_radios; i++) {
+		radio = dm->get_radio(i);
+		if (memcmp(radio->get_radio_interface_mac(), get_radio_interface_mac(), sizeof(mac_address_t)) != 0) {
+				continue;


indentation incorrect, two tabs for continue

amarnathhullur force-pushed the fix branch from a3a8273 to a95df47 Compare March 17, 2025 18:34

amarnathhullur reviewed Mar 17, 2025

View reviewed changes

amarnathhullur requested review from bcarlson-dev and soumyasmunshi March 17, 2025 23:22

amarnathhullur reviewed Mar 18, 2025

View reviewed changes

Fix the stability issues in controller and agent

ea1aa9b

Testing performed: 1)On board remote and local agent 2)Verified not duplicate entries in DB 3)Autoconfig renew success when controller /agent is restarting

AswiniViswanathan force-pushed the fix branch from a95df47 to ea1aa9b Compare March 20, 2025 00:48

amarnathhullur reviewed Mar 20, 2025

View reviewed changes

Merge branch 'rdkcentral:main' into fix

09bfc0b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the stability issues in controller and agent #221

Fix the stability issues in controller and agent #221

AswiniViswanathan commented Mar 15, 2025

amarnathhullur left a comment

amarnathhullur Mar 17, 2025

AswiniViswanathan Mar 18, 2025

AswiniViswanathan Mar 21, 2025

amarnathhullur Mar 17, 2025

AswiniViswanathan Mar 18, 2025

amarnathhullur Mar 17, 2025

AswiniViswanathan Mar 18, 2025

amarnathhullur Mar 18, 2025

AswiniViswanathan Mar 21, 2025

amarnathhullur Mar 17, 2025

AswiniViswanathan Mar 18, 2025

amarnathhullur Mar 17, 2025

AswiniViswanathan Mar 18, 2025

amarnathhullur Mar 17, 2025

amarnathhullur Mar 17, 2025

AswiniViswanathan Mar 18, 2025

amarnathhullur Mar 17, 2025

AswiniViswanathan Mar 18, 2025

amarnathhullur Mar 17, 2025

AswiniViswanathan Mar 18, 2025

amarnathhullur Mar 18, 2025

AswiniViswanathan Mar 21, 2025

amarnathhullur Mar 17, 2025

amarnathhullur Mar 18, 2025

amarnathhullur Mar 18, 2025

amarnathhullur Mar 18, 2025

amarnathhullur Mar 20, 2025

AswiniViswanathan Mar 21, 2025

Fix the stability issues in controller and agent #221

Are you sure you want to change the base?

Fix the stability issues in controller and agent #221

Conversation

AswiniViswanathan commented Mar 15, 2025

amarnathhullur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment