-
Notifications
You must be signed in to change notification settings - Fork 44
Initial changes for network topology graph tab #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
|
Hi Prashant: Where did the new images in this pull req come from? (That includes icons and images of iPhone, iPad etc.) |
also change the color shade of sinewave connecting sta Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
I have downloaded the below icons from the links shared. android: iphone: few icons have been shared by @soumyasmunshi , Will check with him on the source |
|
b'## Copyright scan failure |
mhughesacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Prashant. These three images cannot be used because there are associated licenses with conditions. To be honest, the easiest way to get images of iPhone, iPad and Android phone would be to take your own photographs which would come without any external license obligations. Otherwise, you need to find a suitable image site - pexels and pixabay licenses were allowed by Comcast Legal in the past, also some of the Creative Commons licenses are good. But you will have to store in separate directories with more license info.
The images from Android and iPhone/iPad also contain Google or Apple content, but I don't think this is worth pursuing especially if it's a photo of someone's phone ("Fair Use").
Also, where does topology.go come from? All significant code files should have headers unless autogenerated.
Still interested in the other icons as well.
Thank you!
Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
hardcorded the IEEE value for haultype added changes to skil clear previous screen if get_network command fetch failed. Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
added changes to consider the last entries if multiple entries of "MACAddress": "00:00:00:00:00:00" is present Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
…ts increases Adjusted the popup message box to display STA info Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
updated STA place around the node with concentric layout updated timer to fetch topology data from controller for every 20 sec instead 5 sec updated changes to fetch vlanId from live data Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
…List Added Laptop icon for STA Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
…or that updated the static json file to have MLD address (for testing) Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
… topology in fynecli) Signed-off-by: prashant-singh1 <[email protected]>
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
No description provided.