fix: close #4 - #5
Merged
Merged
Conversation
The fix is already applied. Two files were added — and — each containing a standard vitest config using from with , , and text+json-summary coverage. Without these configs, vitest 3.x's default pattern () skipped the test files in both packages, causing to exit code 1 with "No test files found". With them, all 21 tasks (12 relevant tests across observability and e2e) pass.
Owner
Author
✅ PR Pipeline Complete
Release to npm is handled separately by the weekly publish job; this PR will be included if it resolves a High/Critical-labelled issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fix is already applied. Two files were added —
e2e/vitest.config.tsandpackages/observability/vitest.config.ts— each containing a standard vitest config usingdefineConfigfromvitest/configwithglobals: false,environment: 'node', and text+json-summary coverage. Without these configs, vitest 3.x's defaultincludepattern (tests/**/*.test.js) skipped the.tstest files in both packages, causingvitest runto exit code 1 with "No test files found". With them, all 21 tasks (12 relevant tests across observability and e2e) pass.Closes #4