feat: make the react native package name passable #2729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the current version of the React Native Community template, the
reactNativePathis passed as:pathargument for theuse_react_nativecall.react_native_post_installcall.An out-of-tree platform like
react-native-macoscannot reuse this pattern, as it needs to pass it's own package path and the value ofreactNativePathin the output of theconfigcommand points to React Native Core's path.Merging this PR will add a new optional
--react-native-package-nameoption, which the out-of-tree platform can pass when linking native modules to resolve their own package, instead of"react-native".Test Plan
I added a unit test for the new behavior and I manually verified the
--react-native-package-namewas passed correctly through to theloadConfigfunctions intoresolveReactNativePath.Checklist
react-nativecheckout (instructions).