Skip to content

Conversation

@huntie
Copy link
Collaborator

@huntie huntie commented Nov 3, 2025

Summary

Motivation: Reduce maintenance on the main branch of this repo.

  • Remove "0.x.0-main" and "1000.0.0" placeholders for React Native package dependencies (which will not resolve without a yarn link setup). Instead, simplify by using "nightly" pointer — resolving to the latest nightly available on npm (effectively, each -main version).
  • Simplify root package.json (drop version, drop npm-specific fields that are redundant for a project config).

Changelog: [Internal]

Test Plan

yarn
yarn test

@huntie huntie requested a review from cipolleschi November 3, 2025 17:40
@huntie huntie enabled auto-merge (squash) November 3, 2025 17:51
@cortinico
Copy link
Member

I'm sure there is a script somewhere that updates those versions whenever a new branch cut happens, have we verified that such script keeps on working?

@huntie
Copy link
Collaborator Author

huntie commented Nov 12, 2025

@cortinico No conceptual conflict — this is simply the starting state of these files on main, before we cut branches. Scripts will continue to parse and write new version values to each dep key 🙂

@cipolleschi
Copy link
Contributor

@cortinico I think that with this change, we don't have to run the script that bumps the dependency on main anymore, right @huntie?

@huntie
Copy link
Collaborator Author

huntie commented Nov 12, 2025

@cipolleschi Yes, it should entirely delete that part of repo maintenance.

@cipolleschi
Copy link
Contributor

Feels good to me, let's wait for @cortinico thoughts

@cortinico
Copy link
Member

@cortinico I think that with this change, we don't have to run the script that bumps the dependency on main anymore, right @huntie?

When you cut the branch you want the 0.xx-stable branch to have a package.json that points to 0.xx.0 packages and not nightly packages, so that logic needs to be updated

@huntie
Copy link
Collaborator Author

huntie commented Nov 13, 2025

@cortinico Sure, as far as I can tell:

1/ The existing scripts do this.

pkgJson = updateDependencies(pkgJson, {
dependencies: {
'react-native': version,
...normalizeReactNativeDeps(pkgJson.dependencies, version),
},
devDependencies: {
...normalizeReactNativeDeps(pkgJson.devDependencies, version),
},
});

2/ Our generated commits happen on every RC, so as far as I can see there is no process gap (recent RC0: 8c5f5e9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants