-
Notifications
You must be signed in to change notification settings - Fork 57
Use "nightly" version for all dependencies on main #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm sure there is a script somewhere that updates those versions whenever a new branch cut happens, have we verified that such script keeps on working? |
|
@cortinico No conceptual conflict — this is simply the starting state of these files on |
|
@cortinico I think that with this change, we don't have to run the script that bumps the dependency on main anymore, right @huntie? |
|
@cipolleschi Yes, it should entirely delete that part of repo maintenance. |
438b387 to
d30bcce
Compare
|
Feels good to me, let's wait for @cortinico thoughts |
When you cut the branch you want the |
|
@cortinico Sure, as far as I can tell: 1/ The existing scripts do this. template/scripts/updateReactNativeVersion.js Lines 50 to 58 in ef04031
2/ Our generated commits happen on every RC, so as far as I can see there is no process gap (recent RC0: 8c5f5e9). |
Summary
Motivation: Reduce maintenance on the
mainbranch of this repo."0.x.0-main"and"1000.0.0"placeholders for React Native package dependencies (which will not resolve without ayarn linksetup). Instead, simplify by using"nightly"pointer — resolving to the latest nightly available on npm (effectively, each-mainversion).package.json(drop version, drop npm-specific fields that are redundant for a project config).Changelog: [Internal]
Test Plan