chore: upgrade to React 19, Expo 53, and React Native 0.79.5 #998
+6,181
−8,473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILLIPS71
changed the title
vonovak
requested changes
Aug 28, 2025
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "invariant": "^2.2.4" | ||
| }, | ||
| "peerDependencies": { | ||
| "expo": ">=52.0.0", | ||
| "expo": ">=53.0.0", |
There was a problem hiding this comment.
Suggested change
| "expo": ">=53.0.0", | |
| "expo": ">=52.0.0", |
test/userlandTestExamples.test.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable jest/expect-expect */ | |||
There was a problem hiding this comment.
let's resolve this properly? What error is being reported?
There was a problem hiding this comment.
see: #998 (comment)
jest.config.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| module.exports = { | |||
| preset: 'react-native', | |||
| preset: 'jest-expo', | |||
There was a problem hiding this comment.
Suggested change
| preset: 'jest-expo', | |
| preset: 'react-native', |
let's not mix vanilla RN project with expo
example/e2e/detoxTest.spec.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable jest/expect-expect */ | |||
There was a problem hiding this comment.
I added it as eslint was getting tripped up by the test assertions, since they weren't directly inside the test but came from the assertions.js util file. I silenced the warnings while debugging and forgot to remove them afterwards.
babel.config.js
Outdated
| {useTransformReactJSXExperimental: !isLintingOrTesting}, | ||
| ], | ||
| ], | ||
| presets: ['babel-preset-expo'], |
There was a problem hiding this comment.
let's keep this with vanilla RN babel preset
vonovak
approved these changes
Aug 29, 2025
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Overview
Key Changes
Closes
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)