Should ejecting change lockfile?

[gaearon]

I think the way we run yarn after ejecting doesn't quite make sense because we don't update the lockfile. Should we have been running yarn remove and yarn add for Yarn users instead?

I'm not sure I understand the best practice here.

[luftywiranda13]

I think the lockfile should be regenerated after ejecting. maybe by executing dependencies installation with yarn or by passing --force flag to yarn command.

https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/scripts/eject.js#L219-L225

this is the description of yarn install --force:
install and build packages even if they were built before, overwrite lockfile

[gaearon]

Tagging for contributions. I'm not sure just regenerating lockfile is a good idea since it loses existing lockfile information (which could refer to runtime dependencies). Potentially breaking your code.

We should probably run a bunch of yarn add / yarn remove commands (is it possible to batch them?) While there, whoever looks into this would need to undo #2634 and hopefully figure out a solution to it. So this likely won't be easy.

[gaearon]

I fixed this in #3806.