Move test skipping from Jest config to a filter file#1525
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
Summary: Currently we use `testPathIgnorePatterns` to skip known-broken tests on some configurations (mainly tests that weren't written for Windows). Using `testPathIgnorePatterns` ignores the tests on the file-crawling level. This has the side-effect of changing the file map cache key, which means Metro tests on Windows don't benefit from sharing a cache with posix (i.e., Saved State). This uses Changelog: Internal Differential Revision: D77656335
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77656335 |
Contributor
|
This pull request has been merged in f7a7e0b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently we use
testPathIgnorePatternsto skip known-broken tests on some configurations (mainly tests that weren't written for Windows).Using
testPathIgnorePatternsignores the tests on the file-crawling level. This has the side-effect of changing the file map cache key, which means Metro tests on Windows don't benefit from sharing a cache with posix (i.e., Saved State).This uses
Changelog: Internal
Differential Revision: D77656335