Auto-generate TypeScript types for metro-source-map#1574
Closed
robhogan wants to merge 7 commits into
Closed
Conversation
Summary: Prefer actually-private class field/method syntax (`#` prefix) over private-by-convention (`_` prefix). Flow will already error on use of `_`-private fields, but they will generate TypeScript types as if part of the public API. Also cleans up some inconsistent headers and a stray self-import of a type. This prepares `metro-cache` for fully auto-generated TypeScript types. Differential Revision: D81051149
…vate, misc fixes" Differential Revision: D81879389
Differential Revision: D81125128
Differential Revision: D81128767
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82029338 |
Differential Revision: D82028876
Differential Revision: D82029008
Summary: Pull Request resolved: #1574 Rollback Plan: Differential Revision: D82029338
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82029338 |
robhogan
force-pushed
the
export-D82029338
branch
from
e1a33fe to
547e451
Compare
Contributor
|
This pull request has been merged in 4c346f2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D82029338