Auto-generate TypeScript types for metro-cache#1576
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81125128 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
Summary: Auto-generate TypeScript defs for the `metro-cache` package using `flow-api-translator`, and enforce that they remain in sync. ## Why `metro-cache`? - It's relatively small, so easy to review these changes by eye while this is a new process. - Its types have no dependencies on any other package (Metro, Node or otherwise) - It's a dependency of `metro-config`, which is the most important to start auto-generating in terms of user impact - all RN users interact with `metro-config`'s types. Changelog: Internal Reviewed By: vzaidman Differential Revision: D81125128
facebook-github-bot
force-pushed
the
export-D81125128
branch
from
32e59d0 to
27fddb0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81125128 |
robhogan
added a commit
that referenced
this pull request
Sep 10, 2025
Summary: Auto-generate TypeScript defs for the `metro-cache` package using `flow-api-translator`, and enforce that they remain in sync. ## Why `metro-cache`? - It's relatively small, so easy to review these changes by eye while this is a new process. - Its types have no dependencies on any other package (Metro, Node or otherwise) - It's a dependency of `metro-config`, which is the most important to start auto-generating in terms of user impact - all RN users interact with `metro-config`'s types. Changelog: Internal Reviewed By: vzaidman Differential Revision: D81125128
robhogan
force-pushed
the
export-D81125128
branch
from
27fddb0 to
21858b2
Compare
Summary: Pull Request resolved: #1576 Auto-generate TypeScript defs for the `metro-cache` package using `flow-api-translator`, and enforce that they remain in sync. ## Why `metro-cache`? - It's relatively small, so easy to review these changes by eye while this is a new process. - Its types have no dependencies on any other package (Metro, Node or otherwise) - It's a dependency of `metro-config`, which is the most important to start auto-generating in terms of user impact - all RN users interact with `metro-config`'s types. Changelog: Internal Reviewed By: vzaidman Differential Revision: D81125128
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81125128 |
robhogan
force-pushed
the
export-D81125128
branch
from
21858b2 to
b24ed5f
Compare
Contributor
|
This pull request has been merged in 95e6d90. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Auto-generate TypeScript defs for the
metro-cachepackage usingflow-api-translator, and enforce that they remain in sync.Why
metro-cache?metro-config, which is the most important to start auto-generating in terms of user impact - all RN users interact withmetro-config's types.Changelog: Internal
Reviewed By: vzaidman
Differential Revision: D81125128