metro-core: Make Flow-private fields of Terminal actually private#1579
Closed
robhogan wants to merge 1 commit into
Closed
metro-core: Make Flow-private fields of Terminal actually private#1579robhogan wants to merge 1 commit into
robhogan wants to merge 1 commit into
Conversation
Summary: `_`-prefixed variables are considered private in Flow, and part of the private API by convention. This makes them actually private with the newer `#` prefix. In particular, this prevents `_private` props and methods being added to generated TypeScript types. Though this is private, I had a search around GitHub anyway to make sure this wouldn't break anyone - the only case I can find was in Expo CLI. I've opened expo/expo#39531 to move them onto public APIs. Changelog: Internal Reviewed By: huntie Differential Revision: D82028876
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82028876 |
Contributor
|
This pull request has been merged in c101027. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
_-prefixed variables are considered private in Flow, and part of the private API by convention.This makes them actually private with the newer
#prefix. In particular, this prevents_privateprops and methods being added to generated TypeScript types.Though this is private, I had a search around GitHub anyway to make sure this wouldn't break anyone - the only case I can find was in Expo CLI. I've opened expo/expo#39531 to move them onto public APIs.
Changelog: Internal
Reviewed By: huntie
Differential Revision: D82028876