Fix TypeScript CI lint errors#1581
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2025
Summary: TS lints are currently failing in OSS CI due to three issues: - Verifying generated types are in sync sometimes takes slightly longer than 10s, allow 30s. - Use of Babel ambient types that exist in Flow but not TS - switch to an explicitly imported type instead. - Incorrect mapping of the `ob1` package because its main file is not `index.js` but `ob1.js` https://github.com/facebook/metro/actions/runs/17679616928/job/50250418546?pr=1580 Differential Revision: D82316554
facebook-github-bot
force-pushed
the
export-D82316554
branch
from
21261d2 to
3f01006
Compare
Contributor
Summary: TS lints are currently failing in OSS CI due to three issues: - Verifying generated types are in sync sometimes takes slightly longer than 10s, allow 30s. - Use of Babel ambient types that exist in Flow but not TS - switch to an explicitly imported type instead. - Incorrect mapping of the `ob1` package because its main file is not `index.js` but `ob1.js` https://github.com/facebook/metro/actions/runs/17679616928/job/50250418546?pr=1580 Differential Revision: D82316554
facebook-github-bot
force-pushed
the
export-D82316554
branch
from
3f01006 to
55bc3d1
Compare
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2025
Summary: TS lints are currently failing in OSS CI due to four issues: - Verifying generated types are in sync sometimes takes slightly longer than 10s, allow 30s. - Use of Babel ambient types that exist in Flow but not TS - switch to an explicitly imported type instead. - An intermediate raw mapping type that isn't exported in the TS Babel types - inline it. - Incorrect mapping of the `ob1` package because its main file is not `index.js` but `ob1.js` Differential Revision: D82316554
Contributor
|
This pull request has been merged in e3ad8e0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
TS lints are currently failing in OSS CI due to three issues:
ob1package because its main file is notindex.jsbutob1.jshttps://github.com/facebook/metro/actions/runs/17679616928/job/50250418546?pr=1580
Differential Revision: D82316554