chore: declare contents: read on nightly-tests workflow#1713
chore: declare contents: read on nightly-tests workflow#1713arpitjain099 wants to merge 2 commits into
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
Hi @arpitjain099! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
…write Per @CalixTang review feedback: the comment-on-pr-for-failures job calls github.rest.issues.createComment to post nightly failure summaries on PR #1314, so workflow-level contents: read alone wouldn't be sufficient. Adding per-job permissions keeps the test job at the workflow-level contents: read inherit while granting issues: write only on the job that needs to post comments. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
Good catch @CalixTang, thanks. Pushed a per-job permissions block on |
|
@CalixTang has imported this pull request. If you are a Meta employee, you can view this in D105586767. |
|
@CalixTang merged this pull request in 8dc7fde. |
2 participants
The nightly tests workflow runs the test suite on a cron schedule. Pure CI: checkout + yarn install + jest. No git push, no API write. Other workflows in this repo already declare permissions.