Skip to content

Commit de57be5

Browse files
sammy-SCmeta-codesync[bot]
authored andcommitted
Remove dead StartupLogger::getRunJSBundleEndTime getter
Summary: X-link: #57142 `StartupLogger::getRunJSBundleEndTime()` was a public getter that returned the `runJSBundleEndTime` member, but it had no callers. `NativePerformance` is the only consumer of `StartupLogger` and reads the start-time getters plus `getAppStartupEndTime`, never this end-time getter. This removes the dead getter. The backing member `runJSBundleEndTime` is kept because `logStartupEvent`/`reset` still write it. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D108012912 fbshipit-source-id: ac6348b8223fba8695843340e99d7e277bf4f60a
1 parent bc7c757 commit de57be5

11 files changed

Lines changed: 0 additions & 14 deletions

packages/react-native/ReactCommon/cxxreact/ReactMarker.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,6 @@ double StartupLogger::getRunJSBundleStartTime() {
110110
return runJSBundleStartTime;
111111
}
112112

113-
double StartupLogger::getRunJSBundleEndTime() {
114-
return runJSBundleEndTime;
115-
}
116-
117113
double StartupLogger::getAppStartupEndTime() {
118114
return appStartupEndTime;
119115
}

packages/react-native/ReactCommon/cxxreact/ReactMarker.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ class RN_EXPORT StartupLogger {
9595
double getInitReactRuntimeStartTime();
9696
double getInitReactRuntimeEndTime();
9797
double getRunJSBundleStartTime();
98-
double getRunJSBundleEndTime();
9998
double getAppStartupEndTime();
10099

101100
private:

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11716,7 +11716,6 @@ class facebook::react::ReactMarker::StartupLogger {
1171611716
public double getAppStartupStartTime();
1171711717
public double getInitReactRuntimeEndTime();
1171811718
public double getInitReactRuntimeStartTime();
11719-
public double getRunJSBundleEndTime();
1172011719
public double getRunJSBundleStartTime();
1172111720
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1172211721
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11342,7 +11342,6 @@ class facebook::react::ReactMarker::StartupLogger {
1134211342
public double getAppStartupStartTime();
1134311343
public double getInitReactRuntimeEndTime();
1134411344
public double getInitReactRuntimeStartTime();
11345-
public double getRunJSBundleEndTime();
1134611345
public double getRunJSBundleStartTime();
1134711346
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1134811347
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11569,7 +11569,6 @@ class facebook::react::ReactMarker::StartupLogger {
1156911569
public double getAppStartupStartTime();
1157011570
public double getInitReactRuntimeEndTime();
1157111571
public double getInitReactRuntimeStartTime();
11572-
public double getRunJSBundleEndTime();
1157311572
public double getRunJSBundleStartTime();
1157411573
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1157511574
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13547,7 +13547,6 @@ class facebook::react::ReactMarker::StartupLogger {
1354713547
public double getAppStartupStartTime();
1354813548
public double getInitReactRuntimeEndTime();
1354913549
public double getInitReactRuntimeStartTime();
13550-
public double getRunJSBundleEndTime();
1355113550
public double getRunJSBundleStartTime();
1355213551
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1355313552
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13235,7 +13235,6 @@ class facebook::react::ReactMarker::StartupLogger {
1323513235
public double getAppStartupStartTime();
1323613236
public double getInitReactRuntimeEndTime();
1323713237
public double getInitReactRuntimeStartTime();
13238-
public double getRunJSBundleEndTime();
1323913238
public double getRunJSBundleStartTime();
1324013239
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1324113240
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13410,7 +13410,6 @@ class facebook::react::ReactMarker::StartupLogger {
1341013410
public double getAppStartupStartTime();
1341113411
public double getInitReactRuntimeEndTime();
1341213412
public double getInitReactRuntimeStartTime();
13413-
public double getRunJSBundleEndTime();
1341413413
public double getRunJSBundleStartTime();
1341513414
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1341613415
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8701,7 +8701,6 @@ class facebook::react::ReactMarker::StartupLogger {
87018701
public double getAppStartupStartTime();
87028702
public double getInitReactRuntimeEndTime();
87038703
public double getInitReactRuntimeStartTime();
8704-
public double getRunJSBundleEndTime();
87058704
public double getRunJSBundleStartTime();
87068705
public static facebook::react::ReactMarker::StartupLogger& getInstance();
87078706
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8529,7 +8529,6 @@ class facebook::react::ReactMarker::StartupLogger {
85298529
public double getAppStartupStartTime();
85308530
public double getInitReactRuntimeEndTime();
85318531
public double getInitReactRuntimeStartTime();
8532-
public double getRunJSBundleEndTime();
85338532
public double getRunJSBundleStartTime();
85348533
public static facebook::react::ReactMarker::StartupLogger& getInstance();
85358534
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

0 commit comments

Comments
 (0)