Skip to content

disable subview clipping traversal when view culling is enabled #52903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammy-SC wants to merge 1 commit into from
Closed

disable subview clipping traversal when view culling is enabled #52903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,10 @@ - (void)updateClippedSubviewsWithClipRect:(CGRect)clipRect relativeToView:(UIVie

- (void)_remountChildrenIfNeeded
{
if (ReactNativeFeatureFlags::enableViewCulling()) {
return;
}

CGPoint contentOffset = _scrollView.contentOffset;

if (std::abs(_contentOffsetWhenClipped.x - contentOffset.x) < kClippingLeeway &&
Expand All @@ -961,6 +965,10 @@ - (void)_remountChildrenIfNeeded

- (void)_remountChildren
{
if (ReactNativeFeatureFlags::enableViewCulling()) {
return;
}

[_scrollView updateClippedSubviewsWithClipRect:CGRectInset(_scrollView.bounds, -kClippingLeeway, -kClippingLeeway)
relativeToView:_scrollView];
}
Expand Down
Loading